Repository navigation
Cannot compile browser_tree with type checking on. #4507
Description
@vsavkin accidentally turned off our type checking for the non-cjs tree.
I'm turning it back on, but it fails because of
upgrade/typings/jquery/jquery.d.ts (3186, 13): Subsequent variable declarations must have the same type. Variable '$' must be of type 'cssSelectorHelper', but here has type 'JQueryStatic'.
The reason is well-known and documented at DefinitelyTyped/DefinitelyTyped#2734 : Both JQuery and Selenium define a runtime variable in the global scope named $ so the typings files jquery.d.ts and angular-protractor.d.ts both define the symbol for the benefit of the type-checker, but with different types.
The right solution is to compile the modules/upgrade separately from the testing code that depends on protractor. This is a non-trivial change to the build.
Activity
todoubaba commentedon Oct 4, 2015
Similar problem when the VS Code project contains both angular2 and jquery, the IDE always uses 'node_modules/angular2/ts/typings/angular-protractor.d.ts' first and complains about the $ sign.
angular-automatic-lock-bot commentedon Sep 7, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.