fix(router): router-link does not respect location strategy #4333

Activity

1. btford

   added

   type: bug/fix

   comp: router

   P2: required

   effort1: hours

   on Sep 23, 2015
2. whcmark commented on Sep 23, 2015

   

   whcmark

   on Sep 23, 2015

   More actions

   So all href link should add hash?

   router_link.ts

     onClick(): boolean {
       if((<KeyboardEvent>window.event).metaKey || (<KeyboardEvent>window.event).ctrlKey || (<KeyboardEvent>window.event).shiftKey || typeof this.targetParams !== 'undefined'){
         return true;
       }
   
       this._router.navigateByInstruction(this._navigationInstruction);
       return false;
     }
   
3. btford commented on Sep 23, 2015

   

   btford

   on Sep 23, 2015

   ContributorAuthor

   More actions

   No, but apps where HashLocationStrategy is used should generate links with hashes.
4. rvramesh commented on Sep 24, 2015

   

   rvramesh

   on Sep 24, 2015

   More actions

   This is my first time looking at angular 2 source code. My analysis is as below. Please let me know if it is right.

   The location_strategy.ts should expose a method generateNavigationUrl which should accept a string and return it as is (which is default implementation).

   The hash_location_strategy.ts should override the generateNavigationUrl method and return the string with "#" + url passed.

   The location.ts should expose a new method normalizedNavigationUrl which should accept a stringified instruction just like normalizeAbsolutely and internally call normalizeAbsolutely and pass that output to 'generateNavigationUrl' of the platformStrategy

   Finally router_link.ts should be modified to use the new normalizedNavigationUrl instead of normalizeAbsolutely in the set routeParams method
5. btford commented on Oct 9, 2015

   

   btford

   on Oct 9, 2015

   ContributorAuthor

   More actions

   @rvramesh – exactly right.
6. btford

   added 2 commits that reference this issue on Oct 26, 2015

   wip: fix(router): respect LocationStrategy when constructing url

   ...

   This issue will close once commit 4db4b46 is merged into the 'master' branch.

   4db4b46

   fix(router): respect LocationStrategy when constructing hrefs in links

   ...

   This issue will close once commit 2a3e11d is merged into the 'main' branch.

   2a3e11d
7. btford

   closed this as completedin 2a3e11don Oct 27, 2015
8. angular-automatic-lock-bot commented on Sep 7, 2019

   

   angular-automatic-lock-botBot

   on Sep 7, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
9. angular-automatic-lock-bot

   locked and limited conversation to collaborators on Sep 7, 2019