Skip to content

Router.navigate should have an overload that accepts the tuple #4040

Closed

Description

@johnpapa

Currently router.navigate() only accepts a url as a string, like this

this._router.navigate(``${ROUTES.detail}/${this.currentHero.id}``);

This works, but it would be great to be able to pass the tuple to it like this as another option:

this._router.navigate([ROUTES.detail, {id: this.currentHero.id}]);

Activity

  1. johnpapa commented on Sep 8, 2015

    @johnpapa
    ContributorAuthor

    cc // @wardbell

  2. btford commented on Sep 9, 2015

    @btford
    Contributor

    100% agree. I may even have already filed this issue.

  3. self-assigned this
    on Sep 9, 2015
  4. added this to the alpha-38 milestone on Sep 9, 2015
  5. btford commented on Sep 9, 2015

    @btford
    Contributor

    ah– better yet, I already had a fix in progress. PR incoming.

  6. johnpapa commented on Sep 12, 2015

    @johnpapa
    ContributorAuthor

    @btford thanks, thats great!

  7. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  8. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions