Skip to content

discuss: remove angular2/bootstrap and angular2/render. #4036

Closed

Description

@jeffbcross

In the process of shifting around modules in #3713, it was still necessary to have modules for bootstrap and render that would not be included in the angular dart core module. This is so users can choose if they want the reflective bootstrap exported from angular2/bootstrap, or the static bootstrap exported from angular2/bootstrap_static. So when dart users are creating their root component, they'd import both angular2/core and angular2/bootstrap. But libraries would just import angular2/core, without worrying that it imports dart:html somewhere, which would make it not run in a server environment.

This is unfortunate because now angular2/core has different contents in JavaScript and Dart. I don't have ideas on how we can satisfy the needs of "pick-your-own-bootstrap" for dart, while keeping the core module as representing "everything you need to make an angular app" for both platforms. I think it would be better to not deviate between platforms in this case if we're not able to have the core module have the same contents in both environments. I.e. removing bootstrap from JS angular2/core would be preferable to me than to leave angular2/core as it is now.

@yjbanov do you have some ideas for options?

Activity

  1. mhevery commented on Oct 22, 2015

    @mhevery
    Contributor

    Superseded by: #4834

  2. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  3. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions