refactor: move angular2/lifecycle into angular2/core #4028

Activity

1. jeffbcross

   added

   area: build & ciRelated the build and CI infrastructure of the projectRelated the build and CI infrastructure of the project

   P2: required

   effort1: hours

   refactoringIssue that involves refactoring or code-cleanupIssue that involves refactoring or code-cleanup

   on Sep 7, 2015
2. jeffbcross

   self-assigned this

   on Sep 7, 2015
3. jeffbcross

   added this to the alpha-37 milestone on Sep 7, 2015
4. vicb commented on Sep 8, 2015

   

   vicb

   on Sep 8, 2015

   Contributor

   More actions

   I've only moved the hooks in a separate file for doc purpose (ie to have all of them documented in one place and be able to link to the module from directives inline doc).

   If moving them to core still allows that, I'm +1
5. tyleranton commented on Sep 17, 2015

   

   tyleranton

   on Sep 17, 2015

   More actions

   Is this already being worked on? I'd like to start contributing to this project.
6. jeffbcross commented on Sep 17, 2015

   

   jeffbcross

   on Sep 17, 2015

   ContributorAuthor

   More actions

   @tyleranton please take it!
7. tyleranton commented on Sep 17, 2015

   

   tyleranton

   on Sep 17, 2015

   More actions

   @jeffbcross awesome, will do!
8. jeffbcross

   modified the milestones: alpha-38, alpha-37 on Sep 17, 2015
9. tyleranton commented on Sep 18, 2015

   

   tyleranton

   on Sep 18, 2015

   More actions

   @jeffbcross There's an existing lifecycle folder in src/core

   Should it go in

   modules/angular2/src/core/lifecycle/lifecycle_hooks.ts

   instead of

   modules/angular2/src/core/lifecycle_hooks.ts
10. jeffbcross commented on Sep 23, 2015

    

    jeffbcross

    on Sep 23, 2015

    ContributorAuthor

    More actions

    @tyleranton I would just move it into src/core.
11. tyleranton commented on Sep 24, 2015

    

    tyleranton

    on Sep 24, 2015

    More actions

    @jeffbcross Cool, got it done. Last question.

    Re-export all lifecycle_hooks exports from modules/angular2/core.ts

    When re-exporting all lifecycle_hooks exports, should it be done like so:

    export {
      AfterContentInit,
      AfterContentChecked,
      AfterViewInit,
      AfterViewChecked,
      OnChanges,
      OnDestroy,
      OnInit,
      DoCheck
    } from 'modules/angular2/core';
    

    Or is there a way to specify exporting only lifecycle_hooks from angular2/core?
12. 2 remaining items

    Load more
13. naomiblack

    modified the milestones: alpha-39, alpha-38 on Oct 4, 2015
14. IgorMinar

    modified the milestones: alpha-39, alpha-40, alpha-42This milestone has been deleted, alpha-41 on Oct 5, 2015
15. mhevery commented on Oct 27, 2015

    

    mhevery

    on Oct 27, 2015

    Contributor

    More actions

    This should be in angular2/core/contracts per #4834
16. mhevery

    closed this as completedon Oct 27, 2015
17. mhevery

    reopened this on Oct 27, 2015
18. vsavkin commented on Nov 24, 2015

    

    vsavkin

    on Nov 24, 2015

    Contributor

    More actions

    Fixed here 125fa38
19. vsavkin

    closed this as completedon Nov 24, 2015
20. angular-automatic-lock-bot commented on Sep 7, 2019

    

    angular-automatic-lock-botBot

    on Sep 7, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
21. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 7, 2019