docs(typings): make typings match bundles #4026

Activity

1. jeffbcross

   added

   type: bug/fix

   comp: docs

   P1: urgent

   state: Blocked

   on Sep 7, 2015
2. jeffbcross

   self-assigned this

   on Sep 7, 2015
3. jeffbcross

   added this to the alpha-37 milestone on Sep 7, 2015
4. jeffbcross commented on Sep 23, 2015

   

   jeffbcross

   on Sep 23, 2015

   ContributorAuthor

   More actions

   @mhevery: @IgorMinar and I were just talking about changing the angular2 bundle to not provide an angular2/angular2 import path, but would still include core, router, and http dependencies, which could be imported from their documented export: angular2/core, angular2/http, angular2/router. This would remove some ambiguity for docs, so that we don't have two messages about where to import things from.

   This would be a breaking change, because no consumer could import from angular2/angular2 anymore. I think it makes things simpler, and falls in-line with the discussions you and I have had about de-coupling concerns with bundles, sources, and imports. Do you see any issues with this change?

   CC: @yjbanov @rkirov
5. mhevery commented on Sep 23, 2015

   

   mhevery

   on Sep 23, 2015

   Contributor

   More actions

   @jeffbcross I thought that we will break up, but still keep angular2/angular2 as a super bundle. so you could still import from there. Looks like we need to chat some more about this.
6. pkozlowski-opensource commented on Sep 23, 2015

   

   pkozlowski-opensource

   on Sep 23, 2015

   Member

   More actions

   @jeffbcross I'm experimenting with CJS bundles as discussed yesterday and one thing that comes to my mind now, as we discussing splitting code is this: if we move to CJS and want to have separate bundles for core, http etc. I guess we need to make sure that other bundles (ex. http) only import from "public" part of the core, no? Otherwise we would end up pulling the same code into multiple bundles.

   For example, looking at https://github.com/angular/angular/blob/master/modules/angular2/src/http/http.ts we can see imports like angular2/src/core/facade/async or angular2/src/core/facade/lang. Those would be totally fine with System.register but we need to think harder about those problems when moving to CJS, no?

   Sorry, didn't want to hijack the thread, but since we are talking about splitting bundles and what gets exported where, we need to take this into account.
7. 8 remaining items

   Load more
8. naomiblack

   modified the milestones: alpha-37, alpha-39, alpha-40 on Oct 4, 2015
9. IgorMinar

   modified the milestones: alpha-41, alpha-40 on Oct 7, 2015
10. IgorMinar

    assigned

    IgorMinar

    and unassigned

    jeffbcross

    on Oct 10, 2015
11. alexeagle commented on Oct 10, 2015

    

    alexeagle

    on Oct 10, 2015

    Contributor

    More actions

    Since we are moving away from the typings bundles and tsd/DefinitelyTyped, it would be good for this to work with the individual per-module .d.ts files now produced by the compiler.

    I think we need a couple more files added to the new test.typings.npm task from the typing_spec directory. router is there already, we should add the other use cases we expect users to want like http.
12. alexeagle commented on Oct 10, 2015

    

    alexeagle

    on Oct 10, 2015

    Contributor

    More actions

    in alpha.41, this will work without any typings distribution:

    import {Component, bootstrap, View} from 'angular2/angular2';
    import {RouteConfig, ROUTER_DIRECTIVES, ROUTER_BINDINGS} from 'angular2/router';
    import {ConnectionBackend} from 'angular2/http';
    import {AsyncTestCompleter} from 'angular2/test_lib';
    import {AnimationBuilder} from 'angular2/animate';
    import {DoCheck} from 'angular2/lifecycle_hooks';
    import {MockViewResolver} from 'angular2/mock';
    import {AbstractControl} from 'angular2/web_worker/worker';
    import {WebWorkerApplication} from 'angular2/web_worker/ui';
    

    So I think we could close this. If/when we provide bundled typings again, we'll have to decide the entry points that produce the bundles.
13. alexeagle commented on Oct 13, 2015

    

    alexeagle

    on Oct 13, 2015

    Contributor

    More actions

    There is some good discussion here about bundling, but based on discussion this morning at standup, we don't need to do anything for typings right now, so I'll close this. Please re-open (or file more specific issues) if there is remaining stuff to discuss or do.
14. alexeagle

    closed this as completedon Oct 13, 2015
15. angular-automatic-lock-bot commented on Sep 7, 2019

    

    angular-automatic-lock-botBot

    on Sep 7, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
16. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 7, 2019