You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the treeUpdate benchmark in Chrome 45, benchpress reports scriptTimes and pureScriptTimes that are higher than what was reported in previous versions of chrome:
Chrome 45: ~19ms
Chrome 44: ~9ms
Looking at the browser timeline in chrome 45, the script time should be around 11ms. I am assuming that benchpress is over-reporting in chrome 45.
Note: Chrome Team changed a bunch of event names in Chrome 45, which benchpress depends on. Benchpress has been adapted to those new names (see #3411), but maybe more than just names changed. Further investigation is required.
I just looked at the FunctionCall events produced by Chrome 45 compared to Chrome 44. Looks like Chrome 45 is producing more of them (the extra ones do not have scriptName set) which probably results in the over-reporting. Need to find out what those additional FunctionCalls are and if it is save to just ignore them since they seem to be included in the FunctionCall events with scriptName.
Michael, could we add a logic to not count FunctionCalls that are nested
inside of others in general?
On Fri, Sep 4, 2015 at 8:31 PM Michael Goderbauer [email protected]
wrote:
I just looked at the FunctionCall events produced by Chrome 45 compared to
Chrome 44. Looks like Chrome 45 is producing more of them (the extra ones
do not have scriptName set) which probably results in the over-reporting.
Need to find out what those additional FunctionCalls are and if it is save
to just ignore them since they seem to be included in the FunctionCall
events with scriptName.
Activity
goderbauer commentedon Sep 5, 2015
I just looked at the FunctionCall events produced by Chrome 45 compared to Chrome 44. Looks like Chrome 45 is producing more of them (the extra ones do not have scriptName set) which probably results in the over-reporting. Need to find out what those additional FunctionCalls are and if it is save to just ignore them since they seem to be included in the FunctionCall events with scriptName.
Chrome 45:
Chrome 44:
tbosch commentedon Sep 5, 2015
Michael, could we add a logic to not count FunctionCalls that are nested
inside of others in general?
On Fri, Sep 4, 2015 at 8:31 PM Michael Goderbauer [email protected]
wrote:
goderbauer commentedon Sep 9, 2015
As discussed offline: These events are not nested. Also, that logic already exists:
https://github.com/angular/angular/blob/master/modules/benchpress/src/metric/perflog_metric.ts#L251
angular-automatic-lock-bot commentedon Sep 7, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.