Skip to content

fix(dgeni): correctly export type declarations #3828

Closed

Description

@jeffbcross

For type declarations, such as this one in http interfaces, the d.ts output is type-alias instead of type. This was broken for http.d.ts in master, but apparently was not being tested. Tests now fail with "semicolon expected."

Input:

export type RequestOptionsArgs = {
  url?: string;
  method?: RequestMethods;
  search?: string | URLSearchParams;
  headers?: Headers;
  // TODO: Support Blob, ArrayBuffer, JSON, URLSearchParams, FormData
  body?: string;
  mode?: RequestModesOpts;
  credentials?: RequestCredentialsOpts;
  cache?: RequestCacheOpts;
}

Output:

type-alias RequestOptionsArgs;

Activity

  1. jeffbcross commented on Aug 25, 2015

    @jeffbcross
    ContributorAuthor
  2. mhevery commented on Aug 25, 2015

    @mhevery
    Contributor

    @jeffbcross pleases don't add more then one component to the issue. It confuses the dashboard. If you have a use case for it lets chat.

    Dup of #3699

  3. jeffbcross commented on Aug 25, 2015

    @jeffbcross
    ContributorAuthor

    @mhevery good to know about the component. This doesn't seem like a dupe of #3699, as this is pointing out a bug when using type assignments.

  4. jeffbcross commented on Sep 7, 2015

    @jeffbcross
    ContributorAuthor

    Closed by @IgorMinar with d782616

  5. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions