Skip to content

docs(router): Document PathLocationStrategy as default - #4517

Closed
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:router-default-location-strategy
Closed

brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:router-default-location-strategy

Conversation

@brandonroberts

Copy link
Copy Markdown
Contributor

Updates the default location strategy used by the ROUTER_BINDINGS and routerBindings exports to match the default as stated in the HashLocationStrategy documentation.

@brandonroberts
brandonroberts force-pushed the router-default-location-strategy branch from ff79ca3 to b2141ec Compare October 5, 2015 02:05
@btford

btford commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

Oh jeez– I totally got this backwards.

I think the docs should be updated instead. Would be happy to get a PR doing that, @brandonroberts! Feel free to just force-push to this PR, no need to create a new one

@brandonroberts
brandonroberts force-pushed the router-default-location-strategy branch 2 times, most recently from d2e6c94 to c6379c7 Compare October 5, 2015 20:30
@brandonroberts

Copy link
Copy Markdown
Contributor Author

Sure. PR has been updated with docs fix @btford

@brandonroberts brandonroberts changed the title fix(router): set HashLocationStrategy as default location strategy docs(router): Document PathLocationStrategy as default Oct 5, 2015
@IgorMinar IgorMinar added this to the alpha-39 milestone Oct 5, 2015
@brandonroberts
brandonroberts force-pushed the router-default-location-strategy branch from c6379c7 to c24c153 Compare October 6, 2015 12:15
@naomiblack naomiblack modified the milestones: alpha-39, alpha-40, alpha-41 Oct 6, 2015
@btford

btford commented Oct 9, 2015

Copy link
Copy Markdown
Contributor

Looks good to me– thanks @brandonroberts!

@mary-poppins

Copy link
Copy Markdown

Merging PR #4517 on behalf of @btford to branch presubmit-btford-pr-4517.

@btford btford added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 9, 2015
@btford btford closed this in 075011f Oct 9, 2015
@brandonroberts
brandonroberts deleted the router-default-location-strategy branch March 4, 2016 14:57
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants