Skip to content

Router.subscribe should return StreamSubscription instance #3491

Closed

Description

@tiziano88

Currently Router.subscribe returns void despite just calling ObservableWrapper.subscribe, which instead already returns StreamSubscription. Should be an easy fix.

ref.: https://github.com/angular/angular/blob/master/modules/angular2/src/router/router.ts#L200

Activity

  1. added this to the alpha-36 milestone on Aug 18, 2015
  2. self-assigned this
    on Aug 18, 2015
  3. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  4. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions