Support onbubble-event as alternative to (^event) #3448

Activity

1. pkozlowski-opensource commented on Aug 3, 2015

   

   pkozlowski-opensource

   on Aug 3, 2015

   Member

   More actions

   @manfredsteyer this is probably (?) not what you are looking for, but on-^event="x()" works today. Don't see much problem (apart from introducing yet-another-way-of-doing-things) with adding on-bubble-event="x()"
2. PatrickJS commented on Aug 3, 2015

   

   PatrickJS

   on Aug 3, 2015

   Last edited by PatrickJS

   Contributor

   More actions

   The idea for the alternative syntax is legacy html and user familiarity. For example, we're able to create components/directives that work both in angular 1 and angular 2 following the same interface. This is due to the fact that angular 1 didn't enforce any conventions (since no one knew what the best practices were for component/directives 6 years ago). So we can actually take advantage of this today
   (I gave a subtle nod to a migration technique during ng-vegas)

   ng1 https://github.com/gdi2290/ng-vegas-angular2-d3/blob/master/angular1/app.js#L10
   ng2 https://github.com/gdi2290/ng-vegas-angular2-d3/blob/master/app.ts#L60

   essentially we can create a directive that works in both ng1 and ng2 with this example

   <bar-graph
     bind-data="graphData"
     width="500"
     height="130">
   </bar-graph>

   Notice how we're using the alternative syntax but we can do this for angular 1 today using the alias
   scope: { data: '=bindData' }. We create a directive for each event already in angular 1 (legacy) so it does make sense to continue down that path. Doing this allows you to delete half your code (ng2 means twice as good since it's half the code?) when switching to angular 2 (now that we know what the best practices are)

   
3. mhevery

   added

   type: bug/fix

   P2: required

   effort1: hours

   open for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).An issue that is suitable for a community contributor (based on its complexity/scope).

   comp: core/view/compiler

   on Aug 6, 2015
4. mhevery commented on Aug 6, 2015

   

   mhevery

   on Aug 6, 2015

   Contributor

   More actions

   This should be onbubble-eventsame as (^event)
5. mhevery

   changed the title [-]alternative syntax for binding to bubble-events (^event)[/-] [+]Support `onbubble-event` as alternative to `(^event)`[/+] on Aug 6, 2015
6. vicb

   added 2 commits that reference this issue on Aug 13, 2015

   feat(PropertyBindingParser): support onbubble-event as an alternate s…

   ...

   This issue will close once commit 4c290ac is merged into the 'master' branch.

   4c290ac

   feat(PropertyBindingParser): support onbubble-event as an alternate s…

   ...

   This issue will close once commit 2f8c6ee is merged into the 'master' branch.

   2f8c6ee
7. vicb

   closed this as completedin 1f54e64on Aug 18, 2015
8. angular-automatic-lock-bot commented on Sep 13, 2019

   

   angular-automatic-lock-botBot

   on Sep 13, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
9. angular-automatic-lock-bot

   locked and limited conversation to collaborators on Sep 13, 2019