Skip to content

DomElementBinder#hasNativeShadowRoot is null, not false, resulting in an NPE in... #3230

Closed

Description

@matanlurey

Reported internally. I've hotfixed accordingly there but this needs to be fixed before the next release.

DomRenderer where the check if (binder.hasNativeShadowRoot) is used.

I actually see this problem across the Angular code base, where bools are not set to false, but people instead use the isPresent() check first. That seems very error prone.

Activity

  1. tbosch commented on Jul 23, 2015

    @tbosch
    Contributor

    The cause if probably when text nodes are projected to a place where there is no binding...

  2. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  3. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions