Repository navigation
ng-for and ng-if break with transformer generated change detectors #2984
Description
#2981 provides a test which fails. https://gist.github.com/jakemac53/675fdedad5ce469d292f is an simple example which will fail under the transformer.
Activity
vsavkin commentedon Jul 10, 2015
The actual issue:
The DOM adapter used by the compiler used in the DirectiveProcessor transformer incorrectly reflects on the elements. The adapter cannot detect properly what properties a DOM element has. This problem manifests via change detection.
matanlurey commentedon Jul 13, 2015
Is anyone tackling this? @tbosch mentioned something about registering a Schema last week.
vsavkin commentedon Jul 13, 2015
@matanlurey we'll figure out a plan today. It looks like providing a schema would be a proper solution, but it may take some time. We may have to provide a temporary solution to unblock @jakemac53.
yjbanov commentedon Jul 13, 2015
Assigned to @tbosch as he is already looking into the reflection issue.
tbosch commentedon Jul 13, 2015
Have a PR up, should go in today.
fix(compiler): keep `DOM.hasProperty` in sync between browser and tra…
kevmoo commentedon Jul 14, 2015
Verified on 97ef1c2 with Dartium. Awesome! 🤘
matanlurey commentedon Jul 14, 2015
👍 looks good thanks guys.
jakemac53 commentedon Jul 14, 2015
todomvc works with the transformer now as well :)
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.