Repository navigation
refactor(http): move http into its own module as sibling of angular2 #2680
Description
Since the library's only dependency on angular2 is dependency injection, it could be moved into its own module so that it doesn't add more bytes to the angular 2 bundle for users who may not need it.
May be impacted by #2379, so this task should wait until that's resolved to determine the best approach.
TODO:
- Move files and update imports (unit tests and e2e tests should be passing)
- Create package.json with unique npm package name
- Make typings build step include angular2/angular2_http as separate d.ts file
- Make sure pub release script will correctly publish package (manually test by installing in an application)
- Make sure npm release script will correctly publish module (manually test by installing in an application)
- Add index.ts & index.dart at top-level of angular2_http
- Update paths in all docs
- Check angular.io docs output
- Add README to base directory
- Confirm that bundle/distribution are created consistently with Angular2
- Change ambient module name output in d.ts and bundles to
ngHttp - Add step in npm distribution to include http directory in angular2 package
- Rename angular2_http.ts to http.ts
Activity
jeffbcross commentedon Jul 28, 2015
First two steps are done locally, and I've verified pub publish process with the script at scripts/publish/pub_publish.sh, while manually inspecting the pub output and running
$ pub publish --dry-runto make sure no warnings are generated.Now I need to verify the npm script, then check the typings output, then will open a PR.
jeffbcross commentedon Aug 6, 2015
Moving this to next milestone. I was waiting to make sure we had a consistent distribution story before moving forward, which is somewhat stable now in #3458. Hoping to have this reviewable by tomorrow morning.
refactor(http): move http files to top-level module
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.