Audit dependencies for angular2 in package.json #2448

Activity

1. rkirov

   added

   P3: important

   on Jun 9, 2015
2. rkirov

   added this to the alpha-27 milestone on Jun 9, 2015
3. pkozlowski-opensource commented on Jun 10, 2015

   

   pkozlowski-opensource

   on Jun 10, 2015

   Member

   More actions

   So, I totally agree that we should be more strict about what we put in the https://github.com/angular/angular/blob/master/package.json file, but my understanding is that the package.json that gets pushed to npm is generated from https://github.com/angular/angular/blob/master/modules/angular2/package.json
4. tbosch commented on Jun 10, 2015

   

   tbosch

   on Jun 10, 2015

   Contributor

   More actions

   Yes, this is correct
   On Wed, Jun 10, 2015 at 7:46 AM Pawel Kozlowski [email protected]
   wrote:

   So, I totally agree that we should be more strict about what we put in the
   https://github.com/angular/angular/blob/master/package.json file, but my
   understanding is that the package.json that gets pushed to npm is generated
   from
   https://github.com/angular/angular/blob/master/modules/angular2/package.json

   —
   Reply to this email directly or view it on GitHub
   #2448 (comment).
5. rkirov commented on Jun 10, 2015

   

   rkirov

   on Jun 10, 2015

   ContributorAuthor

   More actions

   @pkozlowski-opensource Right, so technically the top level package.json can never be used as a dependency to other projectes since it is never published to npm.

   The only other case where it matters would be if someone uses jspm github:angular/angular.
6. mhevery

   added

   comp: build/pipeline

   type: chore

   effort1: hours

   on Jun 12, 2015
7. mhevery

   assigned

   rkirov

   on Jun 12, 2015
8. rkirov

   modified the milestones: alpha-28, alpha-27 on Jun 15, 2015
9. jgw96 commented on Jun 22, 2015

   

   jgw96

   on Jun 22, 2015

   More actions

   Hey everyone, i would not mind taking care of this minor issue, we just need to move certain dependencies like gulp-insert from runtime dependencies to to dev dependencies in the https://github.com/angular/angular/blob/master/package.json file correct?
10. jgw96 commented on Jun 22, 2015

    

    jgw96

    on Jun 22, 2015

    More actions

    I have never contributed to Angular before so this looks like a nice, super easy issue to start with. Ive used angularJS 1.3 and now 1.4 for about a year at work, so i have experience using AngularJS and i have messed around and done some little personal projects using Angular and am loving it even more than i love AngularJS.
11. rkirov

    modified the milestones: alpha-29, alpha-28 on Jun 22, 2015
12. rkirov commented on Jun 22, 2015

    

    rkirov

    on Jun 22, 2015

    ContributorAuthor

    More actions

    Go for it, make sure to read https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md

    I don't plan to work on this before the end of the week, but if it is still open before the next alpha, I will handle it myself.
13. naomiblack

    modified the milestones: alpha-29, alpha-31 on Jun 30, 2015
14. rkirov

    closed this as completedin #2964on Jul 9, 2015
15. angular-automatic-lock-bot commented on Sep 6, 2019

    

    angular-automatic-lock-botBot

    on Sep 6, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
16. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 6, 2019