Skip to content

Dart transformers should record interfaces #2204

Closed

Description

@vsavkin

If I have the following class in my app

class MyClass implements MyInterface1, MyInterface2 {}

Dart transformers should record this information in the reflector object, so that I can do the following:

reflector.interfaces(MyClass) //should return [MyInterface1, MyInterface2]

Activity

  1. kegluneq commented on May 28, 2015

    @kegluneq

    What is this being used for? Is there a design document I can read?

  2. naomiblack commented on May 29, 2015

    @naomiblack
    Contributor

    This is the Dart part of completing the work that @yjbanov requested in #2120

  3. self-assigned this
    on Jun 1, 2015
  4. kegluneq commented on Jun 2, 2015

    @kegluneq

    Additional context: #2220

  5. added this to the milestone on Jun 3, 2015
  6. self-assigned this
    on Jun 3, 2015
  7. kegluneq commented on Jun 3, 2015

    @kegluneq

    For which classes does this need to occur?

    1. Every class?
    2. Only @Injectable?
    3. Only @Directive?
    4. Only @Component?

    (1) is possible but will likely defeat tree-shaking, resulting in code bloat. For that reason I'd prefer one of the other options if possible.

  8. kegluneq commented on Jun 3, 2015

    @kegluneq

    Also, is this something that could be done with is checks, which dart2js supports?

    If this information is used in the generation of change detectors (which I imagine it is) the answer is likely "no" since change detectors are created before we ever have an instance of a Type.

  9. added 2 commits that reference this issue on Jun 3, 2015
    b4b2ed9
    dc6e7eb
  10. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  11. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

effort1: hoursfeatureLabel used to distinguish feature request from other issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions