Skip to content

Commit b7d0ab7

Browse files
marclavalbenlesh
marclaval
authored and
benlesh
committed
test(ivy): enable more @angular/core tests (#27912)
PR Close #27912
1 parent 460be79 commit b7d0ab7

1 file changed

Lines changed: 37 additions & 46 deletions

File tree

‎packages/core/test/linker/view_injector_integration_spec.ts‎

Lines changed: 37 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -557,45 +557,38 @@ class TestComp {
557557
.toEqual('parentService');
558558
});
559559

560-
fixmeIvy('FW-890: Overridden providers are not found during dependency resolution')
561-
.it('should instantiate directives that depend on providers of a component', () => {
562-
TestBed.configureTestingModule({declarations: [SimpleComponent, NeedsService]});
563-
TestBed.overrideComponent(
564-
SimpleComponent,
565-
{set: {providers: [{provide: 'service', useValue: 'hostService'}]}});
566-
TestBed.overrideComponent(
567-
SimpleComponent, {set: {template: '<div needsService></div>'}});
568-
const el = createComponent('<div simpleComponent></div>');
569-
expect(el.children[0].children[0].injector.get(NeedsService).service)
570-
.toEqual('hostService');
571-
});
560+
it('should instantiate directives that depend on providers of a component', () => {
561+
TestBed.configureTestingModule({declarations: [SimpleComponent, NeedsService]});
562+
TestBed.overrideComponent(
563+
SimpleComponent, {set: {providers: [{provide: 'service', useValue: 'hostService'}]}});
564+
TestBed.overrideComponent(SimpleComponent, {set: {template: '<div needsService></div>'}});
565+
const el = createComponent('<div simpleComponent></div>');
566+
expect(el.children[0].children[0].injector.get(NeedsService).service)
567+
.toEqual('hostService');
568+
});
572569

573-
fixmeIvy('FW-890: Overridden providers are not found during dependency resolution')
574-
.it('should instantiate directives that depend on view providers of a component', () => {
575-
TestBed.configureTestingModule({declarations: [SimpleComponent, NeedsService]});
576-
TestBed.overrideComponent(
577-
SimpleComponent,
578-
{set: {providers: [{provide: 'service', useValue: 'hostService'}]}});
579-
TestBed.overrideComponent(
580-
SimpleComponent, {set: {template: '<div needsService></div>'}});
581-
const el = createComponent('<div simpleComponent></div>');
582-
expect(el.children[0].children[0].injector.get(NeedsService).service)
583-
.toEqual('hostService');
584-
});
570+
it('should instantiate directives that depend on view providers of a component', () => {
571+
TestBed.configureTestingModule({declarations: [SimpleComponent, NeedsService]});
572+
TestBed.overrideComponent(
573+
SimpleComponent, {set: {providers: [{provide: 'service', useValue: 'hostService'}]}});
574+
TestBed.overrideComponent(SimpleComponent, {set: {template: '<div needsService></div>'}});
575+
const el = createComponent('<div simpleComponent></div>');
576+
expect(el.children[0].children[0].injector.get(NeedsService).service)
577+
.toEqual('hostService');
578+
});
585579

586-
fixmeIvy('FW-890: Overridden providers are not found during dependency resolution')
587-
.it('should instantiate directives in a root embedded view that depend on view providers of a component',
588-
() => {
589-
TestBed.configureTestingModule({declarations: [SimpleComponent, NeedsService]});
590-
TestBed.overrideComponent(
591-
SimpleComponent,
592-
{set: {providers: [{provide: 'service', useValue: 'hostService'}]}});
593-
TestBed.overrideComponent(
594-
SimpleComponent, {set: {template: '<div *ngIf="true" needsService></div>'}});
595-
const el = createComponent('<div simpleComponent></div>');
596-
expect(el.children[0].children[0].injector.get(NeedsService).service)
597-
.toEqual('hostService');
598-
});
580+
it('should instantiate directives in a root embedded view that depend on view providers of a component',
581+
() => {
582+
TestBed.configureTestingModule({declarations: [SimpleComponent, NeedsService]});
583+
TestBed.overrideComponent(
584+
SimpleComponent,
585+
{set: {providers: [{provide: 'service', useValue: 'hostService'}]}});
586+
TestBed.overrideComponent(
587+
SimpleComponent, {set: {template: '<div *ngIf="true" needsService></div>'}});
588+
const el = createComponent('<div simpleComponent></div>');
589+
expect(el.children[0].children[0].injector.get(NeedsService).service)
590+
.toEqual('hostService');
591+
});
599592

600593
it('should instantiate directives that depend on instances in the app injector', () => {
601594
TestBed.configureTestingModule({declarations: [NeedsAppService]});
@@ -961,16 +954,14 @@ class TestComp {
961954
});
962955

963956
describe('pipes', () => {
964-
fixmeIvy('FW-890: Overridden providers are not found during dependency resolution')
965-
.it('should instantiate pipes that have dependencies', () => {
966-
TestBed.configureTestingModule({declarations: [SimpleDirective, PipeNeedsService]});
957+
it('should instantiate pipes that have dependencies', () => {
958+
TestBed.configureTestingModule({declarations: [SimpleDirective, PipeNeedsService]});
967959

968-
const el = createComponent(
969-
'<div [simpleDirective]="true | pipeNeedsService"></div>',
970-
[{provide: 'service', useValue: 'pipeService'}]);
971-
expect(el.children[0].injector.get(SimpleDirective).value.service)
972-
.toEqual('pipeService');
973-
});
960+
const el = createComponent(
961+
'<div [simpleDirective]="true | pipeNeedsService"></div>',
962+
[{provide: 'service', useValue: 'pipeService'}]);
963+
expect(el.children[0].injector.get(SimpleDirective).value.service).toEqual('pipeService');
964+
});
974965

975966
fixmeIvy('FW-894: Pipes don\'t overwrite pipes with later entry in the pipes array')
976967
.it('should overwrite pipes with later entry in the pipes array', () => {

0 commit comments

Comments
 (0)