Skip to content

[JetNews] Bump to alpha07 - #280

Merged
yrezgui merged 10 commits into
android:dev_alpha07from
yrezgui:dev_alpha07
Nov 11, 2020
Merged

yrezgui merged 10 commits into
android:dev_alpha07from
yrezgui:dev_alpha07

Conversation

@yrezgui

@yrezgui yrezgui commented Nov 9, 2020 •

Copy link
Copy Markdown
Collaborator

I'm currently running into a testing issue both in locally and in GitHub actions

@google-cla google-cla Bot added the cla: yes label Nov 9, 2020
@yrezgui

yrezgui commented Nov 9, 2020

Copy link
Copy Markdown
Collaborator Author

I'll merge #266 once this PR is merged

@yrezgui yrezgui changed the title [JetNews] Bump to alpha07 (⚠️ WIP) [JetNews] Bump to alpha07 Nov 9, 2020
Exclude licenses included in META-INF folder from packagingOptions (it was failing tests)
Comment thread JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCardTop.kt Outdated
Comment thread JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCardYourNetwork.kt Outdated

@florina-muntenescu florina-muntenescu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the high emphasis, as that's the default.

Comment thread JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCards.kt

@florina-muntenescu florina-muntenescu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but otherwise looks good

@yrezgui
yrezgui merged commit 8534fc2 into android:dev_alpha07 Nov 11, 2020
@yrezgui
yrezgui deleted the dev_alpha07 branch December 15, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants