Skip to content

Remove Smock npm package and utility files - #155

Merged
zguesmi merged 6 commits into
developfrom
feature/clean-smock-dependencies
Oct 31, 2024
Merged

Remove Smock npm package and utility files#155
zguesmi merged 6 commits into
developfrom
feature/clean-smock-dependencies

Conversation

@zguesmi

@zguesmi zguesmi commented Oct 31, 2024

Copy link
Copy Markdown
Member

No description provided.

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@@ -10,7 +11,6 @@ import { getIexecAccounts } from '../../../utils/poco-tools';

const userBalance = 1000;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename user everywhere to account to harmonize

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Oct 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (3dcbd1f) to head (e4eceba).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #155   +/-   ##
========================================
  Coverage    84.67%   84.67%           
========================================
  Files           35       35           
  Lines         1083     1083           
  Branches       201      221   +20     
========================================
  Hits           917      917           
  Misses         166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi
zguesmi merged commit 825209a into develop Oct 31, 2024
@zguesmi
zguesmi deleted the feature/clean-smock-dependencies branch October 31, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants