Repository navigation
fix: use uuid for test cookie value - #495
Merged
Merged
Conversation
kevinpagtakhan
requested review from
jooohhn,
justin-fiedler,
qingzhuozhen and
yuhao900914
January 27, 2022 18:30
haoliu-amp
approved these changes
Jan 27, 2022
|
Based on output from pull request status check: Micro-Learning Topic: Insecure randomness (Detected by phrase)Matched on "Insecure randomness"This vulnerability manifests when some security construct depends on a random component and this component is somehow guessable -or just not random-. Try this challenge in Secure Code Warrior |
|
This pull request introduces 1 alert when merging 42e1f95 into 064944c - view on LGTM.com new alerts:
|
justin-fiedler
approved these changes
Jan 28, 2022
justin-fiedler
approved these changes
Jan 28, 2022
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 28, 2022
## [8.16.1](v8.16.0...v8.16.1) (2022-01-28) ### Bug Fixes * use Date.now() for test cookie value ([#495](#495)) ([03e270e](03e270e))
|
🎉 This PR is included in version 8.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/amplitude/Amplitude-JavaScript/issues/481
areCookiesEnabled()creates a cookie that gets rejected by firewalls due to some special characters included in TZ names. It should be safe to replace this cookie value with virtually anything (w/o special characters) since this is short lived and only used to determine if cookies are enabled. I decided to change it to a random-ish value, to avoid potential conflict.Checklist