Skip to content

feat: core pacakge for seamless experiment integration - #457

Merged
bgiori merged 23 commits into
mainfrom
bgiori/core
Feb 4, 2022
Merged

bgiori merged 23 commits into
mainfrom
bgiori/core

Conversation

@bgiori

@bgiori bgiori commented Nov 30, 2021 •

Copy link
Copy Markdown
Contributor

Sibling PRs:

Summary

  • Adds dependency on core package for seamless integration with experiment SDK.
  • Core dependency provides IdentityStore and AnalyticsConnector
    • IdentityStore maintains an in memory user identity (including user properties) which can be listened to for changes.
    • AnalyticsConnector allows experiment to send automatic exposure events, including setting and unsetting user properties.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@bgiori
bgiori requested a review from curtisliu December 1, 2021 20:52
Comment thread rollup.config.js Outdated
Comment thread rollup.config.js Outdated
@bgiori
bgiori marked this pull request as ready for review January 14, 2022 17:25
@secure-code-warrior-for-github

Copy link
Copy Markdown

Based on output from pull request status check:

Micro-Learning Topic: Rate limiting (Detected by phrase)

Matched on "rate limiting"

What is this? (2min video)

API requests demand resources such as network, CPU, memory, and storage. The amount of resources required to satisfy a request depends on the user input and endpoint business logic. Not only can this impact the API server performance, leading to Denial of Service (DoS), but it also leaves the door open to authentication flaws such as brute force attacks.

Try this challenge in Secure Code Warrior

@bgiori

bgiori commented Jan 25, 2022

Copy link
Copy Markdown
Contributor Author

@qingzhuozhen @kevinpagtakhan

Any info on the CodeQL check that is failing? Not sure what to do here.

@kevinpagtakhan

Copy link
Copy Markdown
Contributor

Any info on the CodeQL check that is failing?

Seeing it first time here on this PR. But I'd say we can dismiss for now. The server and route is only used for testing.

@bgiori
bgiori merged commit af8f9d1 into main Feb 4, 2022
@bgiori
bgiori deleted the bgiori/core branch February 4, 2022 23:48
github-actions Bot pushed a commit that referenced this pull request Feb 10, 2022
# [8.17.0](v8.16.1...v8.17.0) (2022-02-10)

### Features

* Support seamless integration with amplitude experiment SDK ([#457](#457)) ([af8f9d1](af8f9d1))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 8.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants