Skip to content

feat: add cross origin resource policy header - #426

Merged
ajhorst merged 1 commit into
mainfrom
AMP-42465_cross_origin_header
Sep 16, 2021
Merged

ajhorst merged 1 commit into
mainfrom
AMP-42465_cross_origin_header

Conversation

@ajhorst

@ajhorst ajhorst commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@ajhorst
ajhorst requested a review from jooohhn September 14, 2021 23:58
@ajhorst

ajhorst commented Sep 14, 2021

Copy link
Copy Markdown
Contributor Author

@ajhorst
ajhorst merged commit 709078f into main Sep 16, 2021
@ajhorst
ajhorst deleted the AMP-42465_cross_origin_header branch September 16, 2021 19:56
github-actions Bot pushed a commit that referenced this pull request Sep 16, 2021
# [8.7.0](v8.6.0...v8.7.0) (2021-09-16)

### Features

* add cross origin resource policy header ([#426](#426)) ([709078f](709078f))
@ekanth

ekanth commented Jan 11, 2022 •

Copy link
Copy Markdown

@ajhorst could you please explain why this header was made default? The customer request you reference above isn't accessible so couldn't get the context on this. This is causing HTTP OPTIONS request to be sent out before the first request to amplitude.

Could this header option be controlled by an option/config?

@ajhorst

ajhorst commented Jan 11, 2022

Copy link
Copy Markdown
Contributor Author

Hello @ekanth, this was implemented as a security requirement that some users requested. Are you seeing an issue with the Options request being sent?

CC @kevinpagtakhan

@ekanth

ekanth commented Jan 11, 2022

Copy link
Copy Markdown

We proxy the amplitude requests through a subdomain on our side and this doesn't appear to make sense for that scenario and see a lot of OPTIONS requests after the library upgrade. So, could we make this optional? If default is preferred for most users, could we have a config option to disable/remove this header?

@kevinpagtakhan

Copy link
Copy Markdown
Contributor

Making cors optional: #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants