Skip to content

feat(identify): add preInsert, postInsert, remove to Identify and gro… - #372

Merged
yuhao900914 merged 2 commits into
mainfrom
identifyFunctions
Mar 18, 2021
Merged

yuhao900914 merged 2 commits into
mainfrom
identifyFunctions

Conversation

@yuhao900914

@yuhao900914 yuhao900914 commented Mar 17, 2021 •

Copy link
Copy Markdown
Contributor

…upIdentify

Summary

Implement preInsert, postInsert, remove for identify and identify group.
Add the unit test for testing the new functions.

Checklist

  • Does your PR title have the correct title format? Yes
  • Does your PR have a breaking change?: No

@kelvin-lu kelvin-lu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. some consistency changes with the docs

Comment thread src/identify.js Outdated
@yuhao900914
yuhao900914 merged commit 7e9e992 into main Mar 18, 2021
@yuhao900914
yuhao900914 deleted the identifyFunctions branch March 18, 2021 04:02
github-actions Bot pushed a commit that referenced this pull request Mar 19, 2021
# [8.1.0](v8.0.0...v8.1.0) (2021-03-19)

### Features

* **identify:** add preInsert, postInsert, remove to Identify and gro… ([#372](#372)) ([7e9e992](7e9e992))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants