Skip to content

feat(privacy): Add a storage option - #320

Merged
jooohhn merged 2 commits into
amplitude:masterfrom
bayesimpact:master
Dec 9, 2020
Merged

jooohhn merged 2 commits into
amplitude:masterfrom
bayesimpact:master

Conversation

@pcorpet

@pcorpet pcorpet commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

Summary

As discussed in #317, this PR creates a new option storage to be able to use sessionStorage for persisting the amplitude IDs with the session storage or even noneto not persist anything. These are options are useful for privacy as callers of the Amplitude lib can now limit the persistant footprints on users' browsers.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@pcorpet pcorpet changed the title (feat): Add a storage option fate(privacy): Add a storage option Nov 11, 2020
@pcorpet pcorpet changed the title fate(privacy): Add a storage option feat(privacy): Add a storage option Nov 11, 2020
@kelvin-lu
kelvin-lu self-requested a review November 12, 2020 00:39
@kelvin-lu kelvin-lu self-assigned this Nov 12, 2020
@kelvin-lu
kelvin-lu requested a review from jooohhn November 12, 2020 00:39

@kelvin-lu kelvin-lu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for this PR! This looks good and thanks for updating the tests as well!

@jooohhn jooohhn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcorpet, we'll merge this

@jooohhn
jooohhn merged commit 1a56a9b into amplitude:master Dec 9, 2020
github-actions Bot pushed a commit that referenced this pull request Jan 6, 2021
# [7.4.0](v7.3.3...v7.4.0) (2021-01-06)

### Features

* **privacy:** Add `storage` option ([#320](#320)) ([1a56a9b](1a56a9b)), closes [#317](https://github.com/amplitude/amplitude-javascript/issues/317)
* Added Fbclid config option ([#338](#338)) ([f52288a](f52288a))
@emilieguth
emilieguth deleted the master branch May 28, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants