Skip to content

fix: Prototype js fix - #313

Merged
jooohhn merged 5 commits into
masterfrom
prototype-js-fix
Nov 5, 2020
Merged

fix: Prototype js fix#313
jooohhn merged 5 commits into
masterfrom
prototype-js-fix

Conversation

@jooohhn

@jooohhn jooohhn commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn
jooohhn requested a review from kelvin-lu October 28, 2020 16:52
@jooohhn jooohhn mentioned this pull request Oct 28, 2020
Merged
1 task done
@jooohhn

jooohhn commented Oct 28, 2020

Copy link
Copy Markdown
Contributor Author

Note: Tests will fail until node PR is merged and published so the new APIs will be available

@kelvin-lu

kelvin-lu commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

lgtm but I'll wait til you deploy the joint workspace to give an approval :)

@jooohhn
jooohhn merged commit 7e463ab into master Nov 5, 2020
@jooohhn
jooohhn deleted the prototype-js-fix branch November 5, 2020 18:40
github-actions Bot pushed a commit that referenced this pull request Nov 5, 2020
@amplitude-sdk-bot
chore(release): 7.3.2 [skip ci]
043a3ce 
## [7.3.2](v7.3.1...v7.3.2) (2020-11-05)

### Bug Fixes

* **cookies:** reduce cookie lifetime ([#306](#306)) ([84e1a57](84e1a57))
* Prototype js fix ([#313](#313)) ([7e463ab](7e463ab))
@github-actions

github-actions Bot commented Nov 5, 2020

Copy link
Copy Markdown

🎉 This PR is included in version 7.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kelvin-lu kelvin-lu kelvin-lu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@jooohhn @kelvin-lu