Skip to content

feat: make oninit public - #307

Merged
jooohhn merged 2 commits into
masterfrom
feat-oninit-public
Oct 13, 2020
Merged

jooohhn merged 2 commits into
masterfrom
feat-oninit-public

Conversation

@jooohhn

@jooohhn jooohhn commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Summary

  • Make AmplitudeClient.onInit public. It's stubbed in the snippet, isn't used privately anywhere, and seems like it would be valuable for users who load through snippets.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@kelvin-lu kelvin-lu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is a fix or a feature but lgtm! 💯

@jooohhn

jooohhn commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

IMO a grey area, but I think more a feat because it makes publicly available what wasn't before

@jooohhn
jooohhn merged commit 51d5d43 into master Oct 13, 2020
@jooohhn
jooohhn deleted the feat-oninit-public branch October 13, 2020 20:31
github-actions Bot pushed a commit that referenced this pull request Oct 15, 2020
# [7.3.0](v7.2.2...v7.3.0) (2020-10-15)

### Features

* make oninit public ([#307](#307)) ([51d5d43](51d5d43))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants