Repository navigation
fix: Fall back to the other ways, if the device Id is not available from get queries #302 - #303
Merged
Merged
Conversation
…s not available in the params via amp_device_id. #302
jooohhn
suggested changes
Sep 24, 2020
jooohhn
left a comment
jooohhn
left a comment
Contributor
There was a problem hiding this comment.
Just one small nit. Thank you for the PR!
Contributor
Author
|
@kelvin-lu |
…s not available in the params via amp_device_id. #302
Contributor
Author
|
@jooohhn |
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2020
## [7.2.2](v7.2.1...v7.2.2) (2020-09-25) ### Bug Fixes * Unavailable deviceId fallbacks ([#303](#303)) ([e0d39fd](e0d39fd)), closes [#302](https://github.com/amplitude/amplitude-javascript/issues/302)
|
🎉 This PR is included in version 7.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make _getInitialDeviceId fall back to the other options/a base64Id, if the device Id is not available in the params via amp_device_id in case deviceIdFromUrlParam is true #302
Fixes #302
Please let me know, if there are any problems.
Checklist