Repository navigation
Basic React Native Support - #174
Closed
karlsander wants to merge 2 commits into
Closed
karlsander wants to merge 2 commits into
karlsander wants to merge 2 commits into
Conversation
only do the IE localStorage polyfill if document is defined and safely access window.location.hostname in cookiestorage
Contributor
|
Thanks for tackling this! We'll be working on a version that also leverages AsyncStorage a bit more to make sure sent events are retried and to replace the cookie storage as it looks like that con be flaky on some devices. |
|
@blazzy Thanks for that 🙏 For the AsyncStorage please use https://github.com/react-native-community/async-storage and not the one from React-native as it's deprecated 😉 |
Contributor
|
Closing this in favor of https://github.com/amplitude/Amplitude-ReactNative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #164 but it's just one small bit of the work needed.
With these two variable existence checks, the library can successfully run in a react native app with amplitude-react. Even pretty decently if userId, deviceId, language, platform, etc are provided manually in the setup.
Though support for localStorage / cookies would be way better of course. I think the best approach there would be to provide the ability to pass in a localStorage compatible storage (like react-native-sync-localstorage) with the init options. This can then also cover node.js without bloating the library.