feat: expose stun servers config#36
Merged
Merged
Conversation
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Contributor
|
Awesome @muka . This addresses STUN server config. Merging to master. To fully close #34 , we can also expose TURN servers in external config, although there are no free TURN servers currently available, which is why I removed them from the default config. See here how TURN servers are added in the RTCIceConfiguration. Since each STUN and TURN server config can take several config parameters, we should probably move from .peerjsrc to peerjs-config.yaml file. |
ivelin
pushed a commit
that referenced
this pull request
Nov 3, 2020
# [1.3.0](v1.2.7...v1.3.0) (2020-11-03) ### Features * expose stun servers config ([22f69b3](22f69b3)), closes [#36](#36)
Contributor
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First iteration to expose configurable stun servers and some more parameters. Configuration is stored in
.peerjsrccurrently but can be moved to an external API initialization in future.