Skip to content

addResource should add entries to Resources pbx group - #2

Closed
wildabeast wants to merge 1 commit into
alunny:masterfrom
wildabeast:master
Closed

wildabeast wants to merge 1 commit into
alunny:masterfrom
wildabeast:master

Conversation

@wildabeast

Copy link
Copy Markdown

rather than Plugins group

@mreinstein

Copy link
Copy Markdown
Contributor

hey @wildabeast we're working on making some big changes to pluginstall and this looks like a valuable pull. I tried merging it myself in with some other changes that @imhotep made, but there's a merge conflict. Would you be willing to submit a pull request to the fork @imhotep has? It's here: https://github.com/imhotep/node-xcode

@alunny

alunny commented Oct 15, 2012

Copy link
Copy Markdown
Owner

What's the rationale for this again?

I think there's a strong case for putting everything plugin related in the Plugins group - that if I want to remove it, I know where it will be. There may well be a case for creating an Xcode group for each plugin that gets installed.

alunny pushed a commit that referenced this pull request Oct 15, 2012
Added test for updateProductName
@mreinstein

Copy link
Copy Markdown
Contributor

The rationale from my perspective is xcode projects have a group for resources, which I think intended to include stuff that isn't headers or source (.h and .m). rather than shoving them in with source code. At least, from my perspective that's the rationale. I assume @wildabeast proposed the patch for the same reason. I just saw it, and it seems to make sense so I asked for it as inclusion. And as a secondary goal, to either close the patch or get it merged in in the interests of reducing fragmentation and loose bits lying around.

@alunny

alunny commented Oct 15, 2012

Copy link
Copy Markdown
Owner

meh, I think aa3bd6b is the same thing anyway

@alunny alunny closed this Oct 15, 2012
@alunny alunny reopened this Oct 15, 2012
@alunny

alunny commented Oct 15, 2012

Copy link
Copy Markdown
Owner

Re-opening because I think this is worth a bit more discussion.

A problem with putting resources into the Resources group is that it's asymmetric - it doesn't necessarily make sense (if this is an agnostic Xcode parser, not just a tool for Cordova plugins) for sources or header files to go in the Plugins directory by default either. Should we change all those methods to take a group as an option?

Kingles referenced this pull request in atheerinc/space.vu-node-xcode Sep 12, 2015
@mcgrews3

Copy link
Copy Markdown
Contributor

I believe my latest pull request would address "change all those methods to take group as an option?": #82

@wildabeast wildabeast closed this Feb 20, 2020
@mreinstein

Copy link
Copy Markdown
Contributor

wow, I forgot about this one, it's been so long. Hello out there, fellow cordova'ers! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants