Repository navigation
addResource should add entries to Resources pbx group - #2
wildabeast wants to merge 1 commit into
Conversation
|
hey @wildabeast we're working on making some big changes to pluginstall and this looks like a valuable pull. I tried merging it myself in with some other changes that @imhotep made, but there's a merge conflict. Would you be willing to submit a pull request to the fork @imhotep has? It's here: https://github.com/imhotep/node-xcode |
|
What's the rationale for this again? I think there's a strong case for putting everything plugin related in the Plugins group - that if I want to remove it, I know where it will be. There may well be a case for creating an Xcode group for each plugin that gets installed. |
Added test for updateProductName
|
The rationale from my perspective is xcode projects have a group for resources, which I think intended to include stuff that isn't headers or source (.h and .m). rather than shoving them in with source code. At least, from my perspective that's the rationale. I assume @wildabeast proposed the patch for the same reason. I just saw it, and it seems to make sense so I asked for it as inclusion. And as a secondary goal, to either close the patch or get it merged in in the interests of reducing fragmentation and loose bits lying around. |
|
meh, I think aa3bd6b is the same thing anyway |
|
Re-opening because I think this is worth a bit more discussion. A problem with putting resources into the Resources group is that it's asymmetric - it doesn't necessarily make sense (if this is an agnostic Xcode parser, not just a tool for Cordova plugins) for sources or header files to go in the Plugins directory by default either. Should we change all those methods to take a group as an option? |
Fix path/name quotation
|
I believe my latest pull request would address "change all those methods to take group as an option?": #82 |
|
wow, I forgot about this one, it's been so long. Hello out there, fellow cordova'ers! 👋 |
rather than Plugins group