Repository navigation
Conversation
imhotep
reviewed
Oct 27, 2016
| obj.dstSubfolderSpec = SUBFOLDERSPEC_BY_DESTINATION[DESTINATION_BY_TARGETTYPE[folderType]]; | ||
| console.log("pbxCopyFilesBuildPhase"); | ||
| console.log(obj); | ||
|
|
Collaborator
There was a problem hiding this comment.
Hi, remove console.log()s and add unit tests please
Contributor
Author
|
@imhotep There we go. Lots of tests for this project. 👍 |
Contributor
Author
|
I opened a separate pr in #108 without the path name bugfix, to lower the risk of merging this all in. |
Contributor
Author
|
@chrismowbray I can see why you'd want that, especially for making scripts idempotent etc. I can't promise I will get around to implementing it any time soon though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements PBXShellScriptBuildPhase inside project.addBuildPhase.
Resolves issue #85 and upgrades version to 0.9.0