Skip to content

Installation step for macOS/Linux#1

Merged
yamaszone merged 2 commits into
mainfrom
yamaszone/installation_macos_linux
Aug 17, 2022
Merged

Installation step for macOS/Linux#1
yamaszone merged 2 commits into
mainfrom
yamaszone/installation_macos_linux

Conversation

@yamaszone
Copy link
Copy Markdown
Member

Installation step for macOS/Linux

Copy link
Copy Markdown
Member

@wboayue wboayue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Comment thread README.md Outdated

## Installation

### macOS/Linux
Copy link
Copy Markdown
Member

@wboayue wboayue Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be more obvious what's happening with we had a separate macOS and linux installation command. Or does catalina report linux?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested on Catalina but it should return darwin. I have deliberately made it a one liner to add it easily within pipelines. I have also added OS specific commands for clarity.

Copy link
Copy Markdown

@sventech sventech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@yamaszone yamaszone merged commit 27f74e4 into main Aug 17, 2022
@yamaszone yamaszone deleted the yamaszone/installation_macos_linux branch August 17, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants