Repository navigation
PYTHON-1411 Reproducibility fix for mongodb-python-driver - #343
Closed
shell-over-rice wants to merge 3 commits into
Closed
shell-over-rice wants to merge 3 commits into
shell-over-rice wants to merge 3 commits into
Conversation
behackett
requested changes
Nov 13, 2017
| # General information about the project. | ||
| project = u'PyMongo' | ||
| copyright = u'MongoDB, Inc. 2008-{0}. MongoDB, Mongo, and the leaf logo are registered trademarks of MongoDB, Inc'.format(datetime.date.today().year) | ||
| copyright = u'MongoDB, Inc. MongoDB, Mongo, and the leaf logo are registered trademarks of MongoDB, Inc' |
Member
There was a problem hiding this comment.
I see. The date is still necessary, but it can be static. Change it to "2008-present" instead of removing it.
Contributor
Author
There was a problem hiding this comment.
ok will do that
ShaneHarvey
reviewed
Nov 13, 2017
| @@ -30,7 +30,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Can you remove the now unused "import datetime" above?
Member
|
Merged to master. Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copyright message constructed depends on the system current date. So the build changes everytime(Every year technically) it runs. This dependency should not be there as part of reproducible-builds effort and has been fixed by removing the date alone.