Conversation
Removes some fields not existing anymore and adds the alpha mode field.
- The config came from a Linux configure run with the POSIX feature flags hardcoded. Take the ones that differ on mingw32 from the target. - Use w32threads, and link ws2_32 and bcrypt. - NASM was always called with -f elf64. Pick the object format from the target. - Comment out the d3d11va, d3d12va, Media Foundation, ddagrab and macos_kperf files. Their CONFIG_* are false, so the types they use are never declared and they do not compile. The dxva2 files next to them were already commented out for the same reason. - Gate unix.c and ff_unix_protocol on a new /U/ prefix, meaning every target but Windows. They need sys/un.h. - Restore compat/w32pthreads.h, which missed the n8.1.1 update that made thread.h call win32_thread_setname.
still not fully working, when using this dependency with awebo it will still fail to find `hevc_videotoolbox` and `h264_videotoolbox` # Conflicts: # build.zig
Skip them in categorizeSources.
The upstream configure script autodetects available libraries. This is not helpful for cross compilation. The new function in build.zig generates the list files from the config in build.zig.
brodo
marked this pull request as ready for review
September 27, 2026 10:59
brodo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that the
*_list.cfiles generated by the upstream configure script depend on which libraries are available on the host they are created on. And the host that created the ones that were committed did not have videotoolbox.The function I added creates these list files based on the config in the build script. That also saves us from keeping them up to date manually.
I also rebased master on top of this.