Keep environment-agnostic global attachments and errors visible per environment (fixes #869) - #927

Nice diagnosis. I verified it against the store: #indexGlobalAttachment / #indexGlobalError (packages/core/src/store/store.ts:535-590) route globals without an environment through #resolveGlobalEnvironmentIdentity, which falls back to DEFAULT_ENVIRONMENT_IDENTITY, so the default bucket really is the shared one. The selector looks right, and the tab counters are safe: every global attachment is indexed into exactly one bucket, and generateGlobals filters the flat list and the index by the same written attachment set, so union(attachmentsByEnv) === attachments and the MainReport "All" counter is unchanged.

Three things I would like to see addressed.

1. The same defect is still live in the Quality Gate tab. See packages/web-awesome/src/components/ReportQualityGateResults/index.tsx:118-134.

qualityGateStore has the exact same Record<envId, T[]> shape, and a validation result dispatched without an environment goes through the same store path into the default bucket. So with environments: { "env-a": …, "env-b": … } and a globally failing rule, selecting env-a hits results[currentEnvironment.value] ?? [] on line 119, renders "No quality gate results", and MainReport/index.tsx:194 shows 0. That is exactly the #869 symptom.

It also makes the PR description inaccurate: it says the new behaviour "mirrors how quality gate results behave: filterable per environment, but global when they carry no environment", but Quality Gate has the bug too. After this PR, Global Errors and Quality Gate sit next to each other in the same header and disagree about shared entries.

globalEntriesByEnv and flatGlobalEntriesByEnv drop into ReportQualityGateResults and MainReport/index.tsx:193-196 unchanged. Could you include that here, or open a follow up issue and reword the description?

2. default is a configurable environment id, not a reserved bucket. See packages/web-awesome/src/utils/globals.ts:33.

normalizeEnvironmentDescriptorMap (packages/core/src/utils/environment.ts:78-122) validates ids but does not reserve default, so environments: { default: { matcher }, prod: { matcher } } is accepted and seeded as a real identity. In that config the default bucket holds genuinely environment specific entries, and sharedEntries leaks them into every other environment view plus its tab counter.

Suggestion: treat the default bucket as shared only when default is not one of the report's configured environments. The environment list is already available via the env store.

3. The section header disappears when only the shared bucket is rendered. See ReportGlobalAttachments/index.tsx:79-82 and ReportGlobalErrors/index.tsx:72-75.

The entries.length === 1 && entries[0][0] === DEFAULT_ENVIRONMENT branch now also fires while an environment is selected. Two consequences:

• picker set to default in a multi environment report: the old code went through renderAttachmentSections([[currentEnvironment.value, …]]) and rendered the collapsible environment: "default" (N) header, now it is a bare list;
• the selected environment has no own entries (the case the new e2e test in packages/e2e/test/allure-awesome/features/globals.test.ts asserts): the shared entries render unlabeled, so there is no hint that they are shared rather than specific to the selected environment.

Gating that branch on !currentEnvironment.value keeps the single default bucket rendering for the "All" view and keeps the header everywhere else.

Thanks @todti — all three addressed.

1. Quality Gate. Fixed here. ReportQualityGateResults and the tab counter now use the same globalEntriesByEnv / flatGlobalEntriesByEnv selector, so results without an environment stay visible next to those of the selected one. Side effect: with an environment selected, Quality Gate now renders section headers instead of a bare list, for consistency with point 3 — the should allow to switch between environments… e2e expectations were updated. The PR description no longer claims the globals "mirror" Quality Gate; it lists Quality Gate as a fixed component instead.

2. default as a configured id. Good catch, but the env store can't answer it: #addEnvironments seeds DEFAULT_ENVIRONMENT_IDENTITY whenever the list is empty (store.ts:361), so environments: { foo, bar } already yields [default, foo, bar] in environments.json — a declared default is indistinguishable there. It's now carried explicitly: AllureStore.configuredEnvironmentIds() (optional, third-party stores keep working), generateEnvirontmentsList marks declared identities with configured: true, and sharedEnvironmentId becomes null when default is declared. Backwards compatible; reports without the flag behave as before. This makes the "no changes to the report data model" statement in the description untrue, so that part is rewritten as well.

3. Section header. The plain-list branch is gated on !currentEnvironment.value, the header stays everywhere else, as suggested. The e2e case you pointed at asserts the header now.

Unit tests added for the selector, both globals components, Quality Gate, the store method, the generator and normalizeEnvironmentsWidget; e2e covers the shared Quality Gate bucket and the declared-default case.