Skip to content

Preserve test failures when stack traces cannot be fully rendered #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baev merged 1 commit into from
Jul 22, 2026
+38 −1
Merged

Preserve test failures when stack traces cannot be fully rendered #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,18 @@ private static String getRealThreadName() {

private static String getStackTraceAsString(final Throwable throwable) {
final StringWriter stringWriter = new StringWriter();
throwable.printStackTrace(new PrintWriter(stringWriter));
try {
throwable.printStackTrace(new PrintWriter(stringWriter));
} catch (RuntimeException e) {
if (stringWriter.getBuffer().length() == 0) {
stringWriter.append(throwable.getClass().getName());
}
stringWriter
.append(System.lineSeparator())
.append("[Unable to render the complete stack trace: ")
.append(e.getClass().getName())
.append(']');
}
return stringWriter.toString();
}

Expand Down
26 changes: 26 additions & 0 deletions allure-java-commons/src/test/java/io/qameta/allure/ResultsUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.opentest4j.AssertionFailedError;
import org.opentest4j.ValueWrapper;

import java.io.IOException;
import java.io.Serializable;
import java.lang.annotation.Annotation;
import java.util.List;
Expand All @@ -48,6 +49,10 @@
import static io.qameta.allure.util.ResultsUtils.createTmsLink;
import static io.qameta.allure.util.ResultsUtils.getLinkTypePatternPropertyName;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

@ExtendWith(SystemPropertyExtension.class)
class ResultsUtilsTest {

Expand Down Expand Up @@ -399,6 +404,27 @@ void shouldExtractActualAndExpectedFromOpenTest4jAssertionFailedError() {
assertThat(details.getExpected()).startsWith("expected value (");
}

@Test
@Issue("1035")
void shouldCreateStatusDetailsWhenNestedStackTraceCannotBeRendered() {
final RuntimeException cause = mock(RuntimeException.class);
when(cause.getSuppressed()).thenReturn(null);
final AssertionFailedError error = assertThrows(
AssertionFailedError.class,
() -> assertThrows(IOException.class, () -> {
throw cause;
})
);

final StatusDetails details = getStatusDetailsFor("malformed nested throwable", error);

assertThat(details.getMessage()).startsWith("Unexpected exception type thrown");
assertThat(details.getTrace())
.contains(AssertionFailedError.class.getName())
.contains("Caused by:")
.contains("[Unable to render the complete stack trace: java.lang.NullPointerException]");
}

@Test
void shouldUseOpenTest4jValueWrapperToString() {
final AssertionFailedError error = new AssertionFailedError(
Expand Down
Loading