Fix JSON function error handling when called from DuckDB engine#139
Merged
Conversation
|
|
|
|
When JSON functions (json_overlaps, json_depth, json_unquote) are called from DuckDB engine with invalid input, they previously triggered MySQL error handling (my_error) which is not appropriate in the DuckDB context. This fix adds a `m_caller_is_duckdb` flag to the relevant JSON function classes so that when called from DuckDB, errors are thrown as C++ exceptions (duckdb::InvalidInputException) instead of MySQL errors, allowing DuckDB to handle them properly. Fixes alibaba#136 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JSON functions (json_overlaps, json_depth, json_unquote) are called from DuckDB engine with invalid input, they previously triggered MySQL error handling (my_error) which is not appropriate in the DuckDB context.
This fix adds a
m_caller_is_duckdbflag to the relevant JSON function classes so that when called from DuckDB, errors are thrown as C++ exceptions (duckdb::InvalidInputException) instead of MySQL errors, allowing DuckDB to handle them properly.Fixes #136