Fixed bug with an infinite loop when an array doesn't contain a key

nikitap492 · nikitap492 · commit 014bfda4f906 · 2018-04-19T09:44:48.000+03:00
Fulfilled the code style request
diff --git a/Searches/src/search/IterativeTernarySearch.java b/Searches/src/search/IterativeTernarySearch.java
@@ -34,19 +34,26 @@ public class IterativeTernarySearch implements SearchAlgorithm {
     public <T extends Comparable<T>> int find(T[] array, T key) {
         int left = 0;
         int right = array.length - 1;
-        while (true) {
+
+         while (right > left) {
+
             int leftCmp =  array[left].compareTo(key);
             int rightCmp =  array[right].compareTo(key);
             if (leftCmp == 0) return left;
             if (rightCmp == 0) return right;
 
-            int leftThird = left + (right - left) / 3;
-            int rightThird = right - (right - left) /3;
+            int leftThird = left + (right - left) / 3 + 1;
+            int rightThird = right - (right - left) / 3 - 1;
+
 
-            if (array[leftThird].compareTo(key) <= 0) left = leftThird;
-            else right = rightThird;
+            if (array[leftThird].compareTo(key) <= 0) {
+                left = leftThird;
+            } else {
+                right = rightThird;
+            }
         }
 
+        return -1;
     }
 
 
@@ -64,11 +71,12 @@ public static void main(String[] args) {
         IterativeTernarySearch search = new IterativeTernarySearch();
         int atIndex = search.find(integers, shouldBeFound);
 
-        System.out.println(format("Should be found: %d. Found %d at index %d. An array length %d"
-                , shouldBeFound, integers[atIndex], atIndex, size));
+        System.out.println(format("Should be found: %d. Found %d at index %d. An array length %d",
+                shouldBeFound, integers[atIndex], atIndex, size));
 
         int toCheck = Arrays.binarySearch(integers, shouldBeFound);
-        System.out.println(format("Found by system method at an index: %d. Is equal: %b", toCheck, toCheck == atIndex));
+        System.out.println(format("Found by system method at an index: %d. Is equal: %b",
+                toCheck, toCheck == atIndex));
 
     }
 
