Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: smokeball-tests/javascript-developer-test
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: alchemycs/javascript-developer-test
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 23, 2021

  1. Implement getArnieQuotes() stub function. 

    Changes
* Add constants to remove magic number dependencies
* Add helper function parse response body
* Add helper function request a single quote
* Implement primary function to retrieve Arnie Quotes with error handling
    @alchemycs
    alchemycs committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fd72c08 View commit details
    Browse the repository at this point in the history

  2. Update tests for Arnie Quotes. 

    Changes:
* Add comments for future tech debt fixes
* Add tests for the introduced singular `getArnieQuote()` method
* Add missing test to ensure the GET method is being used
    @alchemycs
    alchemycs committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b945f54 View commit details
    Browse the repository at this point in the history
Loading