Repository navigation
Проектная работа №1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,64 @@ | ||
| import java.util.Scanner; | ||
|
|
||
| public class Main { | ||
| public static void main(String[] args) { | ||
| System.out.println("Hello world!"); | ||
| public class Main{ | ||
| public static void main(String[] args){ | ||
| Scanner scanner = new Scanner(System.in); | ||
| Race race = new Race(); | ||
|
|
||
| for (int i = 1; i <= 3; i++){ | ||
| System.out.println("- Введите название машины №" + i); | ||
| String name; | ||
| while (true){ | ||
| name = scanner.nextLine(); | ||
| if (!name.trim().isEmpty()){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Код для считывания непустой строки с ввода лучше вынести в отдельную функцию - код, разделённый на небольшие функции, легче читать, поддерживать и переиспользовать |
||
| break; | ||
| } else { | ||
| System.out.println("- Неверное название!"); | ||
| } | ||
| } | ||
| System.out.println("- Введите скорость машины №" + i); | ||
| int speed; | ||
| while (true){ | ||
| if(scanner.hasNextInt()){ | ||
| speed = scanner.nextInt(); | ||
| if(speed > 0 && speed <= 250){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода |
||
| scanner.nextLine(); | ||
| break; | ||
| } else { | ||
| System.out.println("- Неверная скорость!"); | ||
| } | ||
| } else { | ||
| System.out.println("- Нужно ввести целое число"); | ||
| scanner.next(); //загуглил, что стоит очищать буффер | ||
| } | ||
| } | ||
| Car car = new Car(name, speed); | ||
| race.getWinner(car); | ||
| } | ||
| System.out.println("Победитель: " + race.winner);} | ||
| } | ||
|
|
||
|
|
||
| class Car{ | ||
| int speed = 0; | ||
| String name; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Поля лучше пометить |
||
|
|
||
| Car(String name, int speed){ | ||
| this.name = name; | ||
| this.speed = speed; | ||
| } | ||
| } | ||
|
|
||
| class Race{ | ||
| String winner = ""; | ||
| int distance = 0; | ||
|
|
||
| public void getWinner(Car car) { | ||
| int distance = car.speed * 24; | ||
| if (distance > this.distance){ | ||
| this.distance = distance; | ||
| winner = car.name; | ||
|
|
||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не рекомендую писать бесконечные циклы через
while (true)- лучше всегда явно прописывать условие выхода из цикла, чтобы уменьшить вероятность ошибиться и повысить читабельность кода