Repository navigation
Conversation
I am adding HillClimbingSearchWithSidewaysMoves.java from AIMA4e. The code was originally written by Ciaran O'Reilly. I think this code is important as SidewaysMoves are very helpful in a case of a Plateaux/shoulder.
Contributor
|
I am unsure of how all the checks have passed successfully for this PR. I suppose |
Contributor
Author
|
I have reimplemented the code from AIMA4e branch and up to my knowledge that code works well. |
Contributor
Author
|
@norvig Please have a look |
Member
|
The implementation is faulty and there are no test cases. Besides, there is no requirement of Hill Climbing with sideways moves as far as AIMA3e is concerned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am adding HillClimbingSearchWithSidewaysMoves.java from AIMA4e for the issue #357
The code was originally written by Ciaran O'Reilly.
I think this code is important as SidewaysMoves are very helpful in a case of a Plateaux/shoulder.