Repository navigation
Conversation
8 tasks done
tkman59
marked this pull request as ready for review
October 7, 2026 20:38
1 task
tkman59
force-pushed
the
test/511-antigravity-restore
branch
from
October 13, 2026 20:48
3050f70 to
d5f8c01
Compare
tkman59
force-pushed
the
feat/511-antigravity-docs
branch
2 times, most recently
from
October 13, 2026 21:22
4bd1de6 to
a591727
Compare
tkman59
force-pushed
the
test/511-antigravity-restore
branch
from
October 13, 2026 21:22
d5f8c01 to
0a2f383
Compare
1 task
blafourcade
reviewed
Oct 14, 2026
blafourcade
left a comment
blafourcade
left a comment
Contributor
There was a problem hiding this comment.
The test passes on its first run: it characterises existing behavior and would not catch a rewrite that keeps lint and aidd-context identical. Fine as such, but the refusal it documents (sync --force aborting on an edited hook script) is real; I reproduced it on the stack tip (see my review on #958). Mergeable once that is fixed or tracked in an issue.
sync --force restores a drifted AIDD skill and leaves a user skill and a user named hook in .agents/hooks.json as they were. The clean case moves into the same file, renamed for both. Refs #511 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
tkman59
force-pushed
the
feat/511-antigravity-docs
branch
from
October 14, 2026 20:52
a591727 to
bd05700
Compare
tkman59
force-pushed
the
test/511-antigravity-restore
branch
from
October 14, 2026 20:52
0a2f383 to
5ea8103
Compare
Author
|
The refusal is fixed in #958 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Proves the last open criterion of #511:
restore(aidd sync) touches only what Antigravity setup wrote. Stacked on #961.🛠️ How it works
antigravity-foreign-files.e2e.test.tsgains async --forcecase: setupaidd-context, add a user named hooklintto.agents/hooks.jsonand a user skill, drift an AIDD skill, sync..agents/hooks.jsonkeepslintandaidd-contextwith the same content. The test compares parsed JSON, not bytes: restore unmerges then remerges its own key, soaidd-contextmoves afterlint.cleancase moves into the same file, renamedclean-antigravity-foreign-file→antigravity-foreign-filesto cover both.🧪 How to verify
cd cli && npx vitest run --project e2e tests/e2e/antigravity-foreign-files.e2e.test.ts: 2 passed.withoutPlugininantigravity-hooks.tsreturn{}fails the sync case on the missinglintkey; the clean case still passes.pnpm test: 7094 passed, 1 skipped. CIcli / Smokegreen.sync --forcerefusal on an edited hook script or entry, found while writing it, is fixed in feat(cli): merge plugin hooks into antigravity's .agents/hooks.json #958 (forcenow reaches the hooks guard; reproductions inantigravity-edited-hooks.e2e.test.ts).aidd_docs/tasks/2026_10/2026_10_14_antigravity-review-fixes/.🔗 Linked issue
Closes #511
✅ I certify
🤖 Generated with Claude Code