Repository navigation
Conversation
This was referenced Oct 5, 2026
tkman59
marked this pull request as ready for review
October 7, 2026 20:38
1 task
tkman59
force-pushed
the
feat/511-antigravity-agents
branch
from
October 13, 2026 20:48
905595b to
50b904d
Compare
tkman59
force-pushed
the
feat/511-antigravity-docs
branch
2 times, most recently
from
October 13, 2026 21:22
4bd1de6 to
a591727
Compare
tkman59
force-pushed
the
feat/511-antigravity-agents
branch
from
October 13, 2026 21:22
50b904d to
c554f27
Compare
blafourcade
reviewed
Oct 14, 2026
blafourcade
left a comment
Contributor
There was a problem hiding this comment.
Reviewed line by line; ran pnpm smoke:antigravity on agy 1.3.5: 4/4 PASS. Several claims below were tested directly.
Major
cli/scripts/smoke-antigravity.sh: "hooks loaded" passes without the project hook. I deleted.agents/hooks.jsonafter setup:memoryfails as expected, buthooks loadedstill reportsloaded 1 named hooks(very likely a global user hook). The negative control in the description only holds on a machine with no global hook. Match theaidd-contextname or an expected count.write-rule.cjsgains anantigravitytarget (path,trigger/globsfrontmatter, 24,000-byte refusal) in a PR described as docs + smoke. Please mention it in the description or split it out.
Minor
trigger: glob/globsis not measured (myagy1.3.5 check was inconclusive forglobandmodel_decision). The per-file limit is real:agytruncates between ~23 and ~25 KB, whilewrite-rule.cjsrefuses. Worth saying "measured, truncated" in the docs.ai-mapping.md:~/.gemini/config/plugins/<plugin>/and.agents/plugins/are not measured.ai-mapping.mdsays.agents/skills/alone "signals both" Codex and Antigravity;tool-detect.mdsays it is "no signal".05-rule-generate/references/tool-paths.md: "all files usetrigger: always_onand omit globs" is ambiguous. A rule with paths isglob, one without isalways_on.- README: the "Docs" link of the Antigravity section points to the subagents page, while the section covers skills, agents and hooks.
- The smoke header says "print mode (
-p) fires no hook" (measured on 1.2.17). On 1.3.5 a-psession filledAGENTS.md, so the interactive/pty part may be unnecessary. The 15-line header and the pinned version could shrink. script -q /dev/null agy ...is BSD syntax; util-linux needsscript -qc "..." /dev/null. Not run on Linux.- Nit: the JSDoc on
registry.tsmostly repeats the function name; only thenullcase adds information.
Checked and fine
- Doc counts (11 archives, 7 flat) match the
ci.ymlmatrix; theantigravity -> AGENTS.mdmapping and its test are consistent acrossupdate_memory.js,tools.md,detection.mdandsync-arguments.md. agyloads direct.mdchildren of.agents/rules/and ignores subfolders, as documented.
…ents/ surfaces update_memory.js accepts antigravity, and the onboarding, memory and generator references gain its paths, frontmatter and detection signals. The rule writer gains an antigravity target: a flat .agents/rules/<slug>.md with Antigravity's trigger frontmatter, refused over its 24,000-byte limit. Refs #511 Co-Authored-By: Claude Opus 5.5 <[email protected]>
pnpm smoke:antigravity installs AIDD into a throwaway project, then checks a logged-in agy expands a skill, loads and fires the memory hook, and lists an AIDD agent. Local only: a turn needs a Google login. Refs #511 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Refs #511 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Refs #511 Co-Authored-By: Claude Opus 5.5 <[email protected]>
tkman59
force-pushed
the
feat/511-antigravity-docs
branch
from
October 14, 2026 20:52
a591727 to
bd05700
Compare
tkman59
force-pushed
the
feat/511-antigravity-agents
branch
from
October 14, 2026 20:52
c554f27 to
32e3886
Compare
Author
|
Thanks, addressed in the smoke and
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Antigravity CLI is documented as a supported flat host, the
aidd-contextskills know its.agents/surfaces, and a local smoke proves a logged-inagyuses whataidd setupwrites. Phase 5 of #511, stacked on #960.🛠️ How it works
antigravitytarget, flat only), docs/MAINTAINERS.md (when to run the local smoke). The README install section states the known limitation: Codex flat also writes.agents/skills/, so removing one of the two deletes skills the other uses.update_memory.jsmapsantigravitytoAGENTS.md; its mirrortools.md, onboarding'sdetection.mdandsync-arguments.mdfollow. Test written first, failed onunknown tool antigravity..agents/skills/,.agents/agents/<name>/agent.mdwithmodel: inheritand a YAMLtoolslist,.agents/rules/<slug>.md(flat,triggerfrontmatter), the named-hook.agents/hooks.jsonshape and itscd .. &&prefix. Detection uses.agents/agents/,.agents/rules/or.agents/hooks.json:.agents/skills/alone is no signal, Codex reads it too.antigravitytarget toaidd-context'swrite-rule.cjs. It writes each rule flat to.agents/rules/<slug>.md, becauseagyreads only the direct children of that folder. A rule with paths getstrigger: glob, adescriptionand comma-joinedglobs. A rule without paths getstrigger: always_onand noglobs. A rendered rule over 24,000 bytes is refused before anything is written, becauseagywas measured truncating rule files near 23 to 25 KB.smoke-antigravity.sh,pnpm smoke:antigravity: setup in a throwaway repo, then evidence from logs and files, never from a turn ending.--add-dir, killed onceAGENTS.mdis refreshed or after 60 s. The hooks check compares the loaded count of two interactive sessions, with and without.agents/hooks.json, so a user-global hook (~/.gemini/config/hooks.json) counts on both sides. Sessions run underscriptwith BSD or util-linux syntax picked at runtime./agents: print mode. An interactive initial prompt is sent as text and never expanded, which this smoke's first version tripped on.not logged into Antigravitybefore reading the stored login, so only a missingOAuth: authenticated successfullyline means logged out.🧪 How to verify
cd cli && pnpm smoke:antigravityon a machine withagylogged in. Run onagy1.3.5, with a user-global hook in~/.gemini/config/hooks.json:.agents/hooks.jsondeleted after setup failshooks(.agents/hooks.json adds no loaded hook (1 with, 1 without)) andmemory, exit 1.agyonPATH:FATAL: agy not on PATH — install Antigravity CLI and log in, exit 1.agyreadsAGENTS.md: in a repo whose onlyAGENTS.mdnames a codeword,agy -i "What is the project codeword?"answered"content":"PELICAN-4217"(transcript).cd cli && pnpm test: 7093 passed, 1 skipped. CIcli / Smokegreen.trigger,globs) and that only direct children of.agents/rules/load. Commands have no Antigravity row: no docs page found.streamGenerateContentlogged after the skill expansion). That print mode fires no hook was not re-measured.🔗 Linked issue
Refs #511
✅ I certify
🤖 Generated with Claude Code