Repository navigation
Conversation
This was referenced Oct 5, 2026
tkman59
marked this pull request as ready for review
October 7, 2026 20:38
1 task
tkman59
force-pushed
the
feat/511-antigravity-memory-hook
branch
2 times, most recently
from
October 13, 2026 20:48
710ca6b to
f7fe515
Compare
tkman59
force-pushed
the
feat/511-antigravity-agents
branch
2 times, most recently
from
October 13, 2026 21:22
50b904d to
c554f27
Compare
tkman59
force-pushed
the
feat/511-antigravity-memory-hook
branch
from
October 13, 2026 21:22
f7fe515 to
90beffc
Compare
blafourcade
requested changes
Oct 14, 2026
blafourcade
left a comment
Contributor
There was a problem hiding this comment.
Reviewed line by line; agents verified live on agy 1.3.5 (an installed aidd-dev-checker answers with its own role).
Major: the bundle numbers do not match
- The description says the budget goes 734 -> 742 KB. The code goes 756 -> 766 (#957), then 766 -> 771 here, and the comment in
check-bundle-size.mjssays 763.0 KB. - The +5.1 KB in that comment also covers the hooks merge from #958, so this PR carries growth it did not cause. Please reconcile the description, the comment and the per-PR split.
Nit
portable-agent.tsgoes throughserializeFrontmatter, which writes a string starting with[and ending with]unquoted. Shared code and no shipped agent is affected, but a description like[WIP] foo [x]or non-stringtoolsitems have no test.
Checked and fine
/agentslistsinherit,flashandproagents and dropsopusand comma-stringtools, exactly as the frontmatter rebuild assumes.- Body links resolve from the nested directory; a blank description throws with the agent name.
…agent.md Antigravity's flat build now writes each plugin agent to .agents/agents/<plugin>-<agent>/agent.md, the nested layout agy documents, with its links resolved from that directory. The frontmatter is rebuilt rather than copied, by a builder Codex flat and Kimi can reuse: name, the source description, model: inherit, and tools as a YAML list when declared. agy 1.2.17 silently drops an agent whose model is opus or whose tools is a comma string. A blank description stops the build with the agent named. The profile declares no AgentsCapability: that would also enable the raw fallback route, which copies Claude frontmatter verbatim. The bundle budget moves from 766 KB to 771 KB, measured at 764.2 KB: +1.8 KB over the hooks merge's 762.4 KB. Co-Authored-By: Claude Opus 5.5 <[email protected]>
tkman59
force-pushed
the
feat/511-antigravity-memory-hook
branch
from
October 14, 2026 20:52
90beffc to
b864c7f
Compare
tkman59
force-pushed
the
feat/511-antigravity-agents
branch
from
October 14, 2026 20:52
c554f27 to
32e3886
Compare
Author
|
Thanks, addressed in the agents commit (stack replayed).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
aidd setup --ai antigravitynow installs AIDD's agents whereagydiscovers them. Phase 4 of #511, stacked on #958.🛠️ How it works
Path.
build.tswrites each plugin agent to.agents/agents/<plugin>-<agent>/agent.md. That nested layout is the oneagydocuments; AIDD never writes<name>.md. Body links are resolved from the nested directory.Frontmatter rebuilt, not copied.
portable-agent.tsis meant to be reused by feat(cli): emit portable Markdown agents under .agents/agents #916 for Codex flat and Kimi. It keeps:name;description(a blank one throwsInvalidAgentFrontmatterError, naming the agent);model: inherit;toolsas a YAML list, only when the source declares tools.Every other key is dropped.
Why rebuild. Measured on
agy1.2.17 with/agents: an agent withmodel: opusand one withtools: view_file, grep_searchare both absent from the list, without any error. An agent with notools, or with Claude tool names in a YAML list, is listed.No
AgentsCapability. That capability would also enable the raw fallback route (flatSectionFile), which copies Claude frontmatter to.agents/agents/<plugin>/<file>.md, a fileagywould drop.setuptakes the built-tree route, which reads this artifact. The plan is updated to match.Bundle budget 766 → 771 KB. Measured with tsup on the stack:
next(stack base)This PR adds 1.8 KB;
check-bundle-size.mjsrecords each branch's own figure.Bracketed values are quoted.
serializeFrontmatterwrites a value raw only when it parses as a JSON array, so a description like[WIP] foo [x]stays a string and Cursor's globs keep their inline array.🧪 How to verify
cd cli && pnpm test: 7093 passed, 1 skipped. CIcli / Smokegreen.antigravity:flatmoves, with 4 fixture agents at.agents/agents/<name>/agent.md.agy1.2.17, fresh git repo:aidd setup --source local --path <framework> --ai antigravity --plugins recommended --yeswrites.agents/agents/aidd-dev-{checker,executor}/agent.md, recorded in.aidd/manifest.json.agy --add-dir <repo> --output-format json -p "/agents"exits 0 with"agents":["aidd-dev-checker","aidd-dev-executor"]. The invented nameaidd-dev-ghostis absent.aidd clean --forceremoves them, and.agents/is gone.AIDD_PORTABLE_AGENT_OKexecution marker is left to feat(cli): emit portable Markdown agents under .agents/agents #916.modelback to the source value fails the model test; computing links from a non-nested path fails the body test.nameat another path.🔗 Linked issue
Refs #511, #916
✅ I certify
🤖 Generated with Claude Code