Repository navigation
docs(aidd-dev): simplify implementation rules and require workflow evidence - #950
Conversation
|
Hello |
|
Qu'est-ce que tu penses de ça ?
Evidemment on répercutera sur les autres skills si tu penses que ça fait sens aussi 🤜 |
Oui, c'est une bonne idée. Le Mermaid est utile ici : il montre clairement le flow pour l’humain comme pour l’IA. Le gain en token est minimal vs la plus value je trouve. Pour les numéros, autant aller au bout et les retirer aussi des noms de fichiers : Tu l’as testé sur quels types et quelles tailles de features ? |
|
@waewoo Yes, this is intentionally out of scope for this PR. I agree that the review should explicitly report missing runtime evidence rather than present the behavior as verified. Could you create a dedicated issue for this? |
Hello @blafourcade, On the gouvernail during the level implementation, this is way I needed this because sometimes it says "done", but it wasn't. Should I also add a default commit behavior? I mean, during the implementation process, by default, which phases/category should be committed? I'll propose something. |
|
@blafourcade as for the removal on the number, I am strongly against it, because it brings:
And I do not see any drawbacks apart from having to choose an order |
Very nice question, I would say: This is the original idea. Having a commit per TASK now (not phase) allows use to pin-point where the AI made a mistake. We want it to follow the plan, and if the plan has been properly made, commits should be logical. But this brings that question: Do you want your git history to have the same sequence as your plans? (I think you should, this will make debugging so much easier IMO) |
|
Thanks @alexsoyes for the clarification! I agree that one commit per validated TASK makes sense for traceability and debugging. Having commits follow the plan's TASK sequence seems like a good approach. My initial concern was about TASK boundaries not always matching logical commit boundaries. After reviewing 01-plan and 02-implement, I see that the framework already addresses much of this through coherent, verifiable phases and commits that include all changes related to a TASK. The only small improvement I'd suggest is making TASK decomposition guidance more explicit in 01-plan: ideally, TASKs should represent coherent, independently verifiable changes, rather than splitting implementation, tests, and documentation by default. That would help ensure the plan naturally produces meaningful commits, as you suggested. Otherwise, I'm aligned with the proposed approach. Thanks! |
🎯 What & why
Implementation could pass isolated checks without exercising the affected workflow. Require a complete successful run with observable evidence at every step before
done.🛠️ How it works
Separate actions from rules and remove repeated Test sections, reducing the skill from 831 to 512 words. Execution checks actual against expected behavior, fixes mismatches, and restarts the workflow. Final repairs revalidate the affected workflow before
implemented. Ban manual formatting while allowing project formatters and hooks.🧪 How to verify
pnpm test:changed: 141 passed, 0 failed, 0 skipped.git diff --checkand commit/push hooks: passed.✅ I certify