Repository navigation
ci: the windows e2e step stops starving its own reporter - #766
Merged
Merged
Conversation
blafourcade
force-pushed
the
ci/windows-e2e-stops-starving-its-own-reporter
branch
from
September 4, 2026 21:51
e3881ac to
cbd3b6c
Compare
cli / Windows failed with every test passing - 39 files, 279 tests, 0 failures, exit 1 - on `[vitest-worker]: Timeout calling "onTaskUpdate"`. Measured on five runs between 2026-09-02 and 2026-09-04, including three plain merges to next and a re-run of the same commit, so it is neither a branch nor a one-off. Vitest transforms modules on its own main thread while every worker calls back into it after each test, and that call has a fixed 60 s timeout no configuration key exposes. On a 4 vCPU Windows runner whose e2e tests each spawn node dist/cli.js, the default pool queued that thread past 60 s. --max-workers=2 on that step alone. The Linux jobs keep the default: they have never produced this. The workflow also now lists itself in its own path filters. It did not, so this fix's first push ran every workflow but the one it changes, and merging it would have run none either - a change to how the suite runs, landing unverified. A red check that names no failing test is worse than a red check. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01VWNxk63AGKkqE8HRqHLjGp
blafourcade
force-pushed
the
ci/windows-e2e-stops-starving-its-own-reporter
branch
from
September 4, 2026 21:57
cbd3b6c to
0afc0aa
Compare
blafourcade
deleted the
ci/windows-e2e-stops-starving-its-own-reporter
branch
September 6, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cli / Windowshas been failing with every test passing:A red check that names no failing test is worse than a red check: it teaches everyone reading it that red means nothing.
Measured
cli e2enextcli e2enextcli e2enextcli e2ecli e2eAll green, exit 1, every time. The re-run rules out a one-off; three plain merges to
nextrule out any one branch. Two other Windows failures in the same window were a different, real fault (a comment that names a source file names one that exists), already fixed.Cause
Vitest transforms modules on its own main thread while every worker calls back into it (
onTaskUpdateafter each test), and that call has a fixed 60 s timeout —DEFAULT_TIMEOUT = 6e4in the bundledbirpc, exposed by no configuration key. On this runner (slow filesystem, an e2e test that spawnsnode dist/cli.jsinside every worker) the default pool of one fork per CPU-but-one queued that main thread past 60 s. The e2e suite has grown all week, which is why one occurrence on 2026-09-02 became four in an evening.Change
--max-workers=2on that one step. Halving the pool halves the transform requests competing for the thread that must answer them. The Linux jobs keep the default — they have never produced this, and slowing them would buy nothing.The workflow never ran on its own changes
Found while opening this PR:
cli CIfilters oncli/**,kanban/**,plugins/aidd-telemetry/**andscripts/__tests__/**. A commit touching only.github/workflows/cli-ci.ymlmatches none of them, so the first push of this very fix ran three workflows and not the one it changes — and merging it would have run nothing either, sincepushfilters the same way. A change to how the suite runs would have landed unverified.The workflow now lists itself. It is the one path whose change alters every job in the file.
A sixth occurrence, on a branch that touches no CI file
While this PR waited, #767 - a change to two domain predicates and nothing else - failed
cli / Windowsthe same way on18e31bb8:[vitest-worker]: Timeout calling "onTaskUpdate", 39 files, 280 tests, 0 failures, exit 1. Six occurrences now, across four different branches and three plain merges tonext. Nothing about the failure is branch-specific, which is what a pool-size fix has to be true of to be the right fix.The committed comment says "five runs" - it was written before this one and stays true as a subset. It is not amended here, because amending it would replace the commit whose Windows run is the evidence this PR is waiting on.
What would prove it wrong
Nothing local: the failure needs that runner. The proof is the runs. If the message returns with the smaller pool, the next step is sharding the step in two, not a larger
--max-workers— written into the plan so the next person does not re-derive it from an empty log.🤖 Generated with Claude Code
https://claude.ai/code/session_01VWNxk63AGKkqE8HRqHLjGp