fix(aidd-dev): name one severity scale across assert, audit and refactor - #997

🎯 What & why

The review grades findings critical, major, minor since #977. Assert's architecture check, the audit template and refactor still called the middle level warning. An audit feeds refactor, and the review grades the same code, so one severity had two names depending on which skill wrote it.

🛠️ How it works

The change only renames warning to major; the audit's definition of the level stays the same:

• 02-assert-architecture.md:18: critical or major.
• audit-template.md:14: the findings are counted as critical, major and minor, and the legend at line 24 now reads 🟡 major.
• 07-refactor/SKILL.md:28: 🔴 critical, 🟡 major, 🟢 minor.

A new guard, aidd-dev-severities-share-one-scale.test.js, fails on any warning left in an aidd-dev skill. It also pins each of the three skills to this scale.

🧪 How to verify

• node scripts/check-tests-leave-git-alone.js -- node --test scripts/__tests__/aidd-dev-severities-share-one-scale.test.js:
  • 4 failures on next, 4 passes on this branch;
  • each test goes red under its own mutation.
• Real runs with claude -p --plugin-dir plugins/aidd-dev on a fixture with a copied formatPrice:
  • three code-quality audits each counted 0 critical, 1 major, 3 minor;
  • two architecture checks rated their violations major;
  • no run wrote warning.

✅ I certify

• I DO CERTIFY I READ EACH LINE OF THE PULL REQUEST BECAUSE I AM A SOFTWARE ENGINEER, NOT A AI PUPPY.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VE16AxC1V9wAMGmGgefe4z