Repository navigation
fix(test): preserve Node in E2E sandbox - #963
Merged
Merged
Conversation
1 task done
AIDD-Session-Id: 01a0ca9a-53ab-7ec2-bdc8-d6a3b3ae164c
blafourcade
force-pushed
the
codex/e2e-sandbox-node-isolation
branch
from
October 7, 2026 12:58
82a4f76 to
98da52b
Compare
alexsoyes
marked this pull request as ready for review
October 9, 2026 03:40
blafourcade
approved these changes
Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
The E2E sandbox excludes directories containing AI tools. When
nodeandcodexshare a directory, this also removes Node. On this machine, the existing Node availability test fails withexpected '' not to be '', blocking the pre-push gate for unrelated changes. This fix was extracted from #747.🛠️ How it works
The sandbox helper puts Node in a temporary, Node-only directory when its original directory must be filtered: a symlink on Unix or a copy on Windows, cleaned up after the tests. It also excludes
opencode. The regression test verifies that Node runs while Codex remains unavailable. Production CLI behavior is unchanged.🧪 How to verify
From
cli/, runpnpm exec vitest run --project=e2e tests/e2e/sandbox-reaches-no-tool-binary.e2e.test.ts. The file passes 4/4 tests on this branch; its existing Node availability test fails onnextwhen Node and Codex are installed together. GitHub checks passed.✅ I certify