Skip to content

sync records a marketplace the host refused, and clean removes it by name #833

Closed

Description

@blafourcade

What happens

MarketplaceSyncSettingsUseCase.activateTool records every marketplace it tried to register in nativeRegistrations.marketplaces, whether or not the host accepted it:

  • registerMarketplace returns registered: true after addMarketplace threw a NativePluginCliError and reclaimOrReport only warned.
  • activateTool pushes { alias, hostName } for every marketplace regardless of registered.

clean then treats that entry as this project's own. For a project-scope marketplace, undoMarketplaceRegistration runs the host's marketplace remove <hostName>. If the host refused the add because it already held a marketplace under that name (for example the person's own aidd-framework), that remove targets the person's registration, not this project's.

Evidence

  • Code reading of marketplace-sync-settings-use-case.ts (registerMarketplace, activateTool) and clean-use-case.ts (undoMarketplaceRegistration).
  • The copilot reproduction in clean undoes a user-scope plugin a project install collided with (cursor, codex, copilot) #829 hit the refusal first: marketplace add answered "already registered from a different catalog".
  • The removal of the person's marketplace by clean was not reproduced end to end. This issue records the gap so it gets its own red test first.

Expected

Only a marketplace the host actually registered for this project is recorded, so clean never removes a registration it did not make.

Related

Same cause as #829 (a project taking over what the person already had), in a different code path. #829 covers plugin refs and cursor plugin files.

Activity

  1. added theissue type on Sep 10, 2026
  2. moved this from Ideation to Todo in AIDD Roadmapon Sep 10, 2026
  3. moved this from Todo to In Progress in AIDD Roadmapon Sep 11, 2026
  4. moved this from In Progress to In review in AIDD Roadmapon Sep 11, 2026
  5. added a commit that references this issue on Sep 11, 2026
    679ab68
  6. moved this from In review to Done in AIDD Roadmapon Sep 11, 2026
  7. closed this as completedby moving to Done in AIDD Roadmapon Sep 11, 2026
  8. moved this from Done to In review in AIDD Roadmapon Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    High

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions