Repository navigation
Conversation
ahoblitz
force-pushed
the
fix/logging-and-string-formatting
branch
2 times, most recently
from
August 16, 2025 13:49
188c146 to
74961ab
Compare
- Replace f-strings with % formatting in logging calls for lazy evaluation - Convert .format() to f-strings in server/models.py __repr__ methods - Add test_venv/ to .gitignore - Use logger.exception() for better error debugging with full tracebacks - Improves performance by avoiding string formatting when log levels are disabled 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ahoblitz
force-pushed
the
fix/logging-and-string-formatting
branch
from
August 16, 2025 13:52
74961ab to
62930b2
Compare
…tz/a2a-python into fix/logging-and-string-formatting
…tz/a2a-python into fix/logging-and-string-formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Changes
This PR optimizes logging performance and modernizes string formatting throughout the codebase.
Logging Performance Optimization
String Formatting Modernization
.format()calls to f-strings inserver/models.pyfor better readability__repr__methodsAdditional Improvements
test_venv/to.gitignoreto prevent virtual environments from being committedPerformance Impact
Using % formatting in logging provides significant performance benefits:
In production with DEBUG disabled, this avoids unnecessary string operations and object conversions.
Fixes NA